Fix MSRV check #1393
Merged
Fix MSRV check #1393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-egn
approved these changes
Jun 9, 2025
|
This will be reverted in RUST-2231 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MSRV task generates a fresh lockfile, which pulls in the latest commit on the bson-rust main branch for the
bson-3dependency, which will break compilation if we haven't yet updated the driver to accommodate any recent breaking changes. This PR updates the MSRV check not to compile withbson-3enabled so that merging PRs isn't blocked on us making the necessary changes in the driver when the bson API breaks. (I'm not concerned about losing coverage because we already test MSRV compilation for the bson crate, so we know a 1.81-compliant version exists.) If this approach sounds good, I'll file a ticket to revert these changes once the 3.0 API is stabilized and integrated into the driver.