-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix(browser): bump [email protected] to fix BigInt issues #1963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1963 +/- ##
=======================================
Coverage 81.15% 81.15%
=======================================
Files 24 24
Lines 1470 1470
Branches 349 349
=======================================
Hits 1193 1193
Misses 193 193
Partials 84 84
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@MaximoLiberata electron tests started failing, any clue why? |
Hi @robertsLando, right now I don't have any clue, I will take a look this weekend. |
Thanks! |
Hi @robertsLando, I've tried to run electron's tests and they failed on my local, I moved to previous commits and they still fail. It seems like an internal issue with electron app startup, nothing to do with the tests. I haven't found a solution yet. |
@MaximoLiberata Thanks for the quick update, let me know if you find a fix 🙏🏼 |
@robertsLando Hello~Have you already pushed the latest code to npm? The version on the npm code side is still "readable stream": "^ 4.4.2". |
@402931261 Sorry forgot to do a new release, 5.10.4 is coming |
thanks a lot~Now I have found my problem😁 |
Ref #1745 #1901 #1890