Skip to content

Commit 7cb054e

Browse files
Merge pull request #155 from marten-seemann/guard-against-nil-addrs
guard against nil {Local,Remote}Addr() return values
2 parents 2f4fae4 + 1a8d3e4 commit 7cb054e

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

net/net.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -248,16 +248,16 @@ func (l *maListener) Accept() (Conn, error) {
248248
var raddr ma.Multiaddr
249249
// This block protects us in transports (i.e. unix sockets) that don't have
250250
// remote addresses for inbound connections.
251-
if nconn.RemoteAddr().String() != "" {
252-
raddr, err = FromNetAddr(nconn.RemoteAddr())
251+
if addr := nconn.RemoteAddr(); addr != nil && addr.String() != "" {
252+
raddr, err = FromNetAddr(addr)
253253
if err != nil {
254254
return nil, fmt.Errorf("failed to convert conn.RemoteAddr: %s", err)
255255
}
256256
}
257257

258258
var laddr ma.Multiaddr
259-
if nconn.LocalAddr().String() != "" {
260-
laddr, err = FromNetAddr(nconn.LocalAddr())
259+
if addr := nconn.LocalAddr(); addr != nil && addr.String() != "" {
260+
laddr, err = FromNetAddr(addr)
261261
if err != nil {
262262
return nil, fmt.Errorf("failed to convert conn.LocalAddr: %s", err)
263263
}

0 commit comments

Comments
 (0)