Skip to content

Refactor out usage of pandas private method #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gfyoung opened this issue Jul 17, 2017 · 0 comments
Closed

Refactor out usage of pandas private method #1240

gfyoung opened this issue Jul 17, 2017 · 0 comments

Comments

@gfyoung
Copy link
Contributor

gfyoung commented Jul 17, 2017 •
edited
Loading

We were renaming a private method in the pandas codebase when this build failed:

https://travis-ci.org/pandas-dev/pandas/jobs/253985437

It appears that seaborn is importing remove_na, which is in fact a private method. You should be able to get away with using an indexer that filters out null values.

xref pandas-dev/pandas#16971

cc @jreback
cc @jbrockmendel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gfyoung