refactor: rename get_columns -> get_column_names

Less ambiguous, thinking `iter_columns` will be a better name to reserve for https://docs.pola.rs/api/python/stable/reference/dataframe/api/polars.DataFrame.iter_columns.html

Author: dangotbanned

narwhals/_arrow/namespace.py

@@ -26,7 +26,7 @@
 from narwhals._expression_parsing import combine_evaluate_output_names
 from narwhals.typing import CompliantNamespace
 from narwhals.utils import Implementation
-from narwhals.utils import get_columns
+from narwhals.utils import get_column_names
 from narwhals.utils import import_dtypes_module
 from narwhals.utils import is_compliant_expr
 
@@ -160,7 +160,7 @@ def all(self: Self) -> ArrowExpr:
             ],
             depth=0,
             function_name="all",
-            evaluate_output_names=get_columns,
+            evaluate_output_names=get_column_names,
             alias_output_names=None,
             backend_version=self._backend_version,
             version=self._version,

narwhals/_arrow/selectors.py

@@ -10,7 +10,7 @@
 from narwhals._arrow.expr import ArrowExpr
 from narwhals.utils import _parse_time_unit_and_time_zone
 from narwhals.utils import dtype_matches_time_unit_and_time_zone
-from narwhals.utils import get_columns
+from narwhals.utils import get_column_names
 from narwhals.utils import import_dtypes_module
 
 if TYPE_CHECKING:
@@ -83,7 +83,7 @@ def all(self: Self) -> ArrowSelector:
         def func(df: ArrowDataFrame) -> list[ArrowSeries]:
             return [df[col] for col in df.columns]
 
-        return selector(self, func, get_columns)
+        return selector(self, func, get_column_names)
 
     def datetime(
         self: Self,

narwhals/_dask/namespace.py

@@ -24,7 +24,7 @@
 from narwhals._expression_parsing import combine_alias_output_names
 from narwhals._expression_parsing import combine_evaluate_output_names
 from narwhals.typing import CompliantNamespace
-from narwhals.utils import get_columns
+from narwhals.utils import get_column_names
 from narwhals.utils import is_compliant_expr
 
 if TYPE_CHECKING:
@@ -58,7 +58,7 @@ def func(df: DaskLazyFrame) -> list[dx.Series]:
             func,
             depth=0,
             function_name="all",
-            evaluate_output_names=get_columns,
+            evaluate_output_names=get_column_names,
             alias_output_names=None,
             backend_version=self._backend_version,
             version=self._version,

narwhals/_dask/selectors.py

@@ -10,7 +10,7 @@
 from narwhals._dask.expr import DaskExpr
 from narwhals.utils import _parse_time_unit_and_time_zone
 from narwhals.utils import dtype_matches_time_unit_and_time_zone
-from narwhals.utils import get_columns
+from narwhals.utils import get_column_names
 from narwhals.utils import import_dtypes_module
 
 if TYPE_CHECKING:
@@ -96,7 +96,7 @@ def all(self: Self) -> DaskSelector:
         def func(df: DaskLazyFrame) -> list[dx.Series]:
             return [df._native_frame[col] for col in df.columns]
 
-        return selector(self, func, get_columns)
+        return selector(self, func, get_column_names)
 
     def datetime(
         self: Self,

narwhals/_duckdb/namespace.py

@@ -24,7 +24,7 @@
 from narwhals._expression_parsing import combine_alias_output_names
 from narwhals._expression_parsing import combine_evaluate_output_names
 from narwhals.typing import CompliantNamespace
-from narwhals.utils import get_columns
+from narwhals.utils import get_column_names
 
 if TYPE_CHECKING:
     import duckdb
@@ -53,7 +53,7 @@ def _all(df: DuckDBLazyFrame) -> list[duckdb.Expression]:
         return DuckDBExpr(
             call=_all,
             function_name="all",
-            evaluate_output_names=get_columns,
+            evaluate_output_names=get_column_names,
             alias_output_names=None,
             backend_version=self._backend_version,
             version=self._version,

narwhals/_duckdb/selectors.py

@@ -12,7 +12,7 @@
 from narwhals._duckdb.expr import DuckDBExpr
 from narwhals.utils import _parse_time_unit_and_time_zone
 from narwhals.utils import dtype_matches_time_unit_and_time_zone
-from narwhals.utils import get_columns
+from narwhals.utils import get_column_names
 from narwhals.utils import import_dtypes_module
 
 if TYPE_CHECKING:
@@ -89,7 +89,7 @@ def all(self: Self) -> DuckDBSelector:
         def func(df: DuckDBLazyFrame) -> list[duckdb.Expression]:
             return [ColumnExpression(col) for col in df.columns]
 
-        return selector(self, func, get_columns)
+        return selector(self, func, get_column_names)
 
     def datetime(
         self: Self,

narwhals/_pandas_like/namespace.py

@@ -22,7 +22,7 @@
 from narwhals._pandas_like.utils import horizontal_concat
 from narwhals._pandas_like.utils import vertical_concat
 from narwhals.typing import CompliantNamespace
-from narwhals.utils import get_columns
+from narwhals.utils import get_column_names
 from narwhals.utils import import_dtypes_module
 from narwhals.utils import is_compliant_expr
 
@@ -135,7 +135,7 @@ def all(self: Self) -> PandasLikeExpr:
             ],
             depth=0,
             function_name="all",
-            evaluate_output_names=get_columns,
+            evaluate_output_names=get_column_names,
             alias_output_names=None,
             implementation=self._implementation,
             backend_version=self._backend_version,

narwhals/_pandas_like/selectors.py

@@ -10,7 +10,7 @@
 from narwhals._pandas_like.expr import PandasLikeExpr
 from narwhals.utils import _parse_time_unit_and_time_zone
 from narwhals.utils import dtype_matches_time_unit_and_time_zone
-from narwhals.utils import get_columns
+from narwhals.utils import get_column_names
 from narwhals.utils import import_dtypes_module
 
 if TYPE_CHECKING:
@@ -84,7 +84,7 @@ def all(self: Self) -> PandasSelector:
         def func(df: PandasLikeDataFrame) -> list[PandasLikeSeries]:
             return [df[col] for col in df.columns]
 
-        return selector(self, func, get_columns)
+        return selector(self, func, get_column_names)
 
     def datetime(
         self: Self,

narwhals/_spark_like/namespace.py

@@ -17,7 +17,7 @@
 from narwhals._spark_like.utils import maybe_evaluate_expr
 from narwhals._spark_like.utils import narwhals_to_native_dtype
 from narwhals.typing import CompliantNamespace
-from narwhals.utils import get_columns
+from narwhals.utils import get_column_names
 
 if TYPE_CHECKING:
     from pyspark.sql import Column
@@ -52,7 +52,7 @@ def _all(df: SparkLikeLazyFrame) -> list[Column]:
         return SparkLikeExpr(
             call=_all,
             function_name="all",
-            evaluate_output_names=get_columns,
+            evaluate_output_names=get_column_names,
             alias_output_names=None,
             backend_version=self._backend_version,
             version=self._version,

narwhals/_spark_like/selectors.py

@@ -10,7 +10,7 @@
 from narwhals._spark_like.expr import SparkLikeExpr
 from narwhals.utils import _parse_time_unit_and_time_zone
 from narwhals.utils import dtype_matches_time_unit_and_time_zone
-from narwhals.utils import get_columns
+from narwhals.utils import get_column_names
 from narwhals.utils import import_dtypes_module
 
 if TYPE_CHECKING:
@@ -84,7 +84,7 @@ def all(self: Self) -> SparkLikeSelector:
         def func(df: SparkLikeLazyFrame) -> list[Column]:
             return [df._F.col(col) for col in df.columns]
 
-        return selector(self, func, get_columns)
+        return selector(self, func, get_column_names)
 
     def datetime(
         self: Self,

narwhals/utils.py

@@ -1305,7 +1305,7 @@ def dtype_matches_time_unit_and_time_zone(
     )
 
 
-def get_columns(df: NativeFrame) -> Sequence[str]:
+def get_column_names(df: NativeFrame) -> Sequence[str]:
     return df.columns