Skip to content

Commit 1e11be2

Browse files
authored
Update karma dependencies on neo4j-driver (#1131)
This PR also fix some tests which are using done/async in a inconsistent way. This solves: https://github.com/neo4j/neo4j-javascript-driver/security/dependabot/107
1 parent ebb93fa commit 1e11be2

File tree

6 files changed

+198
-253
lines changed

6 files changed

+198
-253
lines changed

packages/neo4j-driver/package-lock.json

Lines changed: 54 additions & 99 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/neo4j-driver/package.json

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -58,16 +58,14 @@
5858
"gulp-uglify": "^3.0.2",
5959
"gulp-watch": "^5.0.1",
6060
"jasmine-spec-reporter": "^7.0.0",
61-
"karma": "^6.4.1",
62-
"karma-chrome-launcher": "^3.1.1",
63-
"karma-edge-launcher": "^0.4.2",
61+
"karma": "^6.4.2",
62+
"karma-chrome-launcher": "^3.2.0",
6463
"karma-firefox-launcher": "^2.1.2",
65-
"karma-ie-launcher": "^1.0.0",
66-
"karma-jasmine": "^4.0.2",
64+
"karma-jasmine": "^5.1.0",
6765
"karma-source-map-support": "^1.4.0",
6866
"karma-spec-reporter": "^0.0.36",
69-
"karma-typescript": "^5.5.3",
70-
"karma-typescript-es6-transform": "^5.5.3",
67+
"karma-typescript": "^5.5.4",
68+
"karma-typescript-es6-transform": "^5.5.4",
7169
"lolex": "^6.0.0",
7270
"minimist": "^1.2.8",
7371
"rollup": "^2.77.4-1",

packages/neo4j-driver/test/bolt-v3.test.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ describe('#integration Bolt V3 API', () => {
6565
const result = await session.run(
6666
'CALL dbms.listTransactions()',
6767
{},
68-
{ metadata: metadata }
68+
{ metadata }
6969
)
7070
const receivedMetadatas = result.records.map(r => r.get('metaData'))
7171
expect(receivedMetadatas).toContain(metadata)
@@ -184,7 +184,7 @@ describe('#integration Bolt V3 API', () => {
184184
c: [1, 2, 3]
185185
}
186186

187-
const tx = session.beginTransaction({ metadata: metadata })
187+
const tx = session.beginTransaction({ metadata })
188188

189189
// call listTransactions procedure that should list itself with the specified metadata
190190
const result = await tx.run('CALL dbms.listTransactions()')
@@ -218,7 +218,8 @@ describe('#integration Bolt V3 API', () => {
218218
if (
219219
e.code !== 'Neo.ClientError.Transaction.TransactionTimedOut' &&
220220
e.code !== 'Neo.TransientError.Transaction.LockClientStopped' &&
221-
e.code !== 'Neo.ClientError.Transaction.LockClientStopped'
221+
e.code !== 'Neo.ClientError.Transaction.LockClientStopped' &&
222+
e.code !== 'Neo.ClientError.Transaction.TransactionTimedOutClientConfiguration'
222223
) {
223224
fail('Expected transaction timeout error but got: ' + e.code)
224225
}
@@ -461,8 +462,8 @@ describe('#integration Bolt V3 API', () => {
461462

462463
const txFunctionWithMetadata = work =>
463464
read
464-
? session.readTransaction(work, { metadata: metadata })
465-
: session.writeTransaction(work, { metadata: metadata })
465+
? session.readTransaction(work, { metadata })
466+
: session.writeTransaction(work, { metadata })
466467

467468
const result = await txFunctionWithMetadata(tx =>
468469
tx.run('CALL dbms.listTransactions()')

0 commit comments

Comments
 (0)