Skip to content

Commit 6dd433a

Browse files
szaimenszaimen
committed
address review
Signed-off-by: Simon L <[email protected]>
1 parent 18916f4 commit 6dd433a

File tree

9 files changed

+14
-14
lines changed

9 files changed

+14
-14
lines changed

‎apps/files/js/filelist.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -666,7 +666,7 @@
666666
* @param {string} [tabId] optional tab id to select
667667
*/
668668
showDetailsView: function(fileName, tabId) {
669-
OC.debug && console.debug('showDetailsView is deprecated! Use OCA.Files.Sidebar.activeTab. It will be removed in nextcloud 20.');
669+
OC.debug && console.warn('showDetailsView is deprecated! Use OCA.Files.Sidebar.activeTab. It will be removed in nextcloud 20.');
670670
this._updateDetailsView(fileName);
671671
if (tabId) {
672672
OCA.Files.Sidebar.setActiveTab(tabId);
@@ -3879,7 +3879,7 @@
38793879
* Register a tab view to be added to all views
38803880
*/
38813881
registerTabView: function(tabView) {
3882-
OC.debug && console.debug('registerTabView is deprecated! It will be removed in nextcloud 20.');
3882+
OC.debug && console.warn('registerTabView is deprecated! It will be removed in nextcloud 20.');
38833883
const enabled = tabView.canDisplay || undefined
38843884
if (tabView.id) {
38853885
OCA.Files.Sidebar.registerTab(new OCA.Files.Sidebar.Tab({
@@ -3905,7 +3905,7 @@
39053905
* Register a detail view to be added to all views
39063906
*/
39073907
registerDetailView: function(detailView) {
3908-
OC.debug && console.debug('registerDetailView is deprecated! It will be removed in nextcloud 20.');
3908+
OC.debug && console.warn('registerDetailView is deprecated! It will be removed in nextcloud 20.');
39093909
if (detailView.el) {
39103910
OCA.Files.Sidebar.registerSecondaryView(detailView)
39113911
}

‎apps/files/js/files.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@
281281
* @deprecated used OCA.Files.FileList.generatePreviewUrl instead
282282
*/
283283
generatePreviewUrl: function(urlSpec) {
284-
OC.debug && console.debug('DEPRECATED: please use generatePreviewUrl() from an OCA.Files.FileList instance');
284+
OC.debug && console.warn('DEPRECATED: please use generatePreviewUrl() from an OCA.Files.FileList instance');
285285
return OCA.Files.App.fileList.generatePreviewUrl(urlSpec);
286286
},
287287

@@ -290,7 +290,7 @@
290290
* @deprecated used OCA.Files.FileList.lazyLoadPreview instead
291291
*/
292292
lazyLoadPreview : function(path, mime, ready, width, height, etag) {
293-
OC.debug && console.debug('DEPRECATED: please use lazyLoadPreview() from an OCA.Files.FileList instance');
293+
OC.debug && console.warn('DEPRECATED: please use lazyLoadPreview() from an OCA.Files.FileList instance');
294294
return FileList.lazyLoadPreview({
295295
path: path,
296296
mime: mime,

‎apps/files_sharing/src/services/ExternalLinkActions.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ export default class ExternalLinkActions {
5252
* @return {boolean}
5353
*/
5454
registerAction(action) {
55-
OC.debug && console.debug('OCA.Sharing.ExternalLinkActions is deprecated, use OCA.Sharing.ExternalShareAction instead')
55+
OC.debug && console.warn('OCA.Sharing.ExternalLinkActions is deprecated, use OCA.Sharing.ExternalShareAction instead')
5656

5757
if (typeof action === 'object' && action.icon && action.name && action.url) {
5858
this._state.actions.push(action)

‎core/src/OC/capabilities.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,6 @@ import { getCapabilities as realGetCapabilities } from '@nextcloud/capabilities'
3232
* @since 14.0.0
3333
*/
3434
export const getCapabilities = () => {
35-
OC.debug && console.debug('OC.getCapabilities is deprecated and will be removed in Nextcloud 21. See @nextcloud/capabilities')
35+
OC.debug && console.warn('OC.getCapabilities is deprecated and will be removed in Nextcloud 21. See @nextcloud/capabilities')
3636
return realGetCapabilities()
3737
}

‎core/src/OC/util.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ export default {
124124
*/
125125
formatDate(timestamp, format) {
126126
if (window.TESTING === undefined) {
127-
OC.debug && console.debug('OC.Util.formatDate is deprecated and will be removed in Nextcloud 21. See @nextcloud/moment')
127+
OC.debug && console.warn('OC.Util.formatDate is deprecated and will be removed in Nextcloud 21. See @nextcloud/moment')
128128
}
129129
format = format || 'LLL'
130130
return moment(timestamp).format(format)
@@ -136,7 +136,7 @@ export default {
136136
*/
137137
relativeModifiedDate(timestamp) {
138138
if (window.TESTING === undefined) {
139-
OC.debug && console.debug('OC.Util.relativeModifiedDate is deprecated and will be removed in Nextcloud 21. See @nextcloud/moment')
139+
OC.debug && console.warn('OC.Util.relativeModifiedDate is deprecated and will be removed in Nextcloud 21. See @nextcloud/moment')
140140
}
141141
const diff = moment().diff(moment(timestamp))
142142
if (diff >= 0 && diff < 45000) {

‎core/src/OCA/search.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export default class Search {
2626
* @deprecated 20.0.0, will be removed in Nextcloud 22
2727
*/
2828
constructor() {
29-
OC.debug && console.debug('OCA.Search is deprecated. Please use the unified search API instead')
29+
OC.debug && console.warn('OCA.Search is deprecated. Please use the unified search API instead')
3030
}
3131

3232
}

‎core/src/Polyfill/tooltip.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,13 @@ $.prototype.tooltip = (function(tooltip) {
3131
} catch (ex) {
3232
if (ex instanceof TypeError && config === 'destroy') {
3333
if (window.TESTING === undefined) {
34-
OC.debug && console.debug('Deprecated call $.tooltip(\'destroy\') has been deprecated and should be removed')
34+
OC.debug && console.warn('Deprecated call $.tooltip(\'destroy\') has been deprecated and should be removed')
3535
}
3636
return tooltip.call(this, 'dispose')
3737
}
3838
if (ex instanceof TypeError && config === 'fixTitle') {
3939
if (window.TESTING === undefined) {
40-
OC.debug && console.debug('Deprecated call $.tooltip(\'fixTitle\') has been deprecated and should be removed')
40+
OC.debug && console.warn('Deprecated call $.tooltip(\'fixTitle\') has been deprecated and should be removed')
4141
}
4242
return tooltip.call(this, '_fixTitle')
4343
}

‎core/src/globals.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ import { getToken as getRequestToken } from './OC/requesttoken.js'
5656

5757
const warnIfNotTesting = function() {
5858
if (window.TESTING === undefined) {
59-
OC.debug && console.debug.apply(console, arguments)
59+
OC.debug && console.warn.apply(console, arguments)
6060
}
6161
}
6262

‎core/src/jquery/placeholder.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ const toRgb = (s) => {
140140
}
141141

142142
String.prototype.toRgb = function() {
143-
OC.debug && console.debug('String.prototype.toRgb is deprecated! It will be removed in Nextcloud 22.')
143+
OC.debug && console.warn('String.prototype.toRgb is deprecated! It will be removed in Nextcloud 22.')
144144

145145
return toRgb(this)
146146
}

0 commit comments

Comments
 (0)