Skip to content

Commit 566dd0a

Browse files
committed
fix: removed namespaced rbac rules since they don't actually work
1 parent 1e1d77c commit 566dd0a

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed

.gitignore

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,4 @@ KubernetesWithRetry.cs
104104
/Test/TestOperator/Manifests
105105
/Lib/Neon.Kube.Models/.buildComplete
106106
/Services/neon-dashboard/package-lock.json
107-
/Test/Test.Neon.Kube.Operator/**.yaml
108-
/Lib/Neon.Kube.Setup/Resources/Helm/neon-cluster-operator/crds/*.yaml
109-
/Lib/Neon.Kube.Setup/Resources/Helm/neon-cluster-operator/templates/clusterrole-neon-cluster-operator.yaml
110-
/Lib/Neon.Kube.Setup/Resources/Helm/neon-cluster-operator/templates/role-neon-cluster-operator.yaml
107+
*.g.yaml

Services/neon-cluster-operator/Controllers/GlauthController.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,7 @@ namespace NeonClusterOperator
5555
MaxConcurrentReconciles = 1)]
5656
[RbacRule<V1Secret>(
5757
Verbs = RbacVerb.All,
58-
Scope = EntityScope.Cluster,
59-
Namespace = KubeNamespace.NeonSystem)]
58+
Scope = EntityScope.Cluster)]
6059
[RbacRule<V1Pod>(Verbs = RbacVerb.List)]
6160
public class GlauthController : ResourceControllerBase<V1Secret>
6261
{

Services/neon-cluster-operator/Controllers/Sso/NeonSsoClientController.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ namespace NeonClusterOperator
5050
/// </para>
5151
/// </summary>
5252
[RbacRule<V1NeonSsoClient>(Verbs = RbacVerb.All, Scope = EntityScope.Cluster, SubResources = "status")]
53-
[RbacRule<V1ConfigMap>(Verbs = RbacVerb.Get | RbacVerb.Update, Scope = EntityScope.Namespaced, Namespace = KubeNamespace.NeonSystem, ResourceNames = "neon-sso-oauth2-proxy")]
53+
[RbacRule<V1ConfigMap>(Verbs = RbacVerb.Get | RbacVerb.Update, Scope = EntityScope.Namespaced, ResourceNames = "neon-sso-oauth2-proxy")]
5454
[ResourceController(MaxConcurrentReconciles = 1)]
5555
public class NeonSsoClientController : ResourceControllerBase<V1NeonSsoClient>
5656
{

Services/neon-cluster-operator/Service.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ namespace NeonClusterOperator
120120
/// </remarks>
121121
[RbacRule<V1ConfigMap>(Verbs = RbacVerb.All, Scope = EntityScope.Cluster)]
122122
[RbacRule<V1Secret>(Verbs = RbacVerb.All, Scope = EntityScope.Cluster)]
123-
[RbacRule<V1Pod>(Verbs = RbacVerb.List, Scope = EntityScope.Namespaced, Namespace = KubeNamespace.NeonSystem)]
123+
[RbacRule<V1Pod>(Verbs = RbacVerb.List, Scope = EntityScope.Namespaced)]
124124
public partial class Service : NeonService
125125
{
126126
private const int dexPort = 5557;

0 commit comments

Comments
 (0)