Skip to content

NGF is reloading NGINX for HTTPRoutes with no accepted Gateway #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ciarams87 opened this issue Oct 10, 2023 · 1 comment
Closed

NGF is reloading NGINX for HTTPRoutes with no accepted Gateway #1123

ciarams87 opened this issue Oct 10, 2023 · 1 comment
Labels
area/performance Performance related backlog Currently unprioritized work. May change with user feedback or as the product progresses. bug Something isn't working

Comments

@ciarams87
Copy link
Contributor

Describe the bug
We are reloading after reconciling a HTTPRoute even when there is no accepted Gateway and no config being generated.

To Reproduce
Steps to reproduce the behavior:

Deploy a HTTPRoute referring to a Gateway that has not yet been created. Observe that NGINX config files are being regenerated and NGINX is reloaded.

Expected behavior
NGINX should not be reloaded when no NGINX config changes have occurred. In this specific case, without any accepted Gateway, we do not write anything new to the http.conf file, meaning there are no changes to be reloaded.

Your environment
GKE cluster:

  • Node count: 3
  • Instance Type: e2-medium
  • k8s version: 1.27.4-gke.900
  • Zone: europe-west2-b
  • Total vCPUs: 6
  • Total RAM: 12GB
  • Max pods per node: 110

NGF deployment:

  • NGF version: edge - git commit 72b6c6e
  • NGINX Version: 1.25.2

Additional context
See #1116
@ciarams87 ciarams87 changed the title NGF is reloading NGINX even when no config is being generated NGF is reloading NGINX for HTTPRoutes with no accepted Gateway Oct 10, 2023
@ja20222 ja20222 added area/performance Performance related bug Something isn't working backlog Currently unprioritized work. May change with user feedback or as the product progresses. labels Nov 21, 2023
@kate-osborn kate-osborn added temp good first issue Good for newcomers and removed temp labels Dec 18, 2023
@pleshakov pleshakov mentioned this issue Jan 11, 2024
Merged
6 tasks
@ciarams87 ciarams87 mentioned this issue Feb 14, 2024
Merged
6 tasks
@ciarams87 ciarams87 mentioned this issue Mar 11, 2024
Open
@kate-osborn kate-osborn self-assigned this Mar 26, 2024
@pleshakov pleshakov mentioned this issue Apr 26, 2024
Merged
6 tasks
@lucacome lucacome moved this from 🆕 New to 🏗 In Progress in NGINX Gateway Fabric Jan 8, 2025
@kate-osborn kate-osborn removed the good first issue Good for newcomers label Jan 28, 2025
@sjberman
Copy link
Collaborator

No longer relevant with the 2.0 architecture.

@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in NGINX Gateway Fabric Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/performance Performance related backlog Currently unprioritized work. May change with user feedback or as the product progresses. bug Something isn't working
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sjberman @ciarams87 @kate-osborn @ja20222