Skip to content

niflow-nipype1-workflows is now a dependency #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
oesteban opened this issue Oct 8, 2019 · 5 comments
Closed

niflow-nipype1-workflows is now a dependency #410

oesteban opened this issue Oct 8, 2019 · 5 comments
Milestone
1.0.0

Comments

@oesteban
Copy link
Member

oesteban commented Oct 8, 2019

After nipy/nipype#3067 was merged, we need to list niflow-nipype1-workflows as a dependency. Is that correct, @effigies ?
@oesteban
Copy link
Member Author

oesteban commented Oct 8, 2019

Should this issue be upstreamed to nipype?

@effigies
Copy link
Member

effigies commented Oct 8, 2019

Why? Do we use one of its workflows?

And we can depend on it, but because it depends on nipype, nipype cannot depend on it.

@mgxd
Copy link
Contributor

mgxd commented Oct 8, 2019

yeah, this is leading to issues with the build.

https://circleci.com/gh/poldracklab/fmriprep/9929?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@effigies
Copy link
Member

effigies commented Oct 8, 2019

Ah, that looks like sdcflows needs to update its dependencies.

@oesteban oesteban added this to the 1.0.0 milestone Oct 15, 2019
@oesteban
Copy link
Member Author

We just need to make sure we pin sdcflows >=0.1.3 wherever needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@effigies @oesteban @mgxd