Skip to content

Commit fc8e991

Browse files
committed
RF: Simplify serialization
1 parent 7df2d62 commit fc8e991

File tree

1 file changed

+6
-17
lines changed

1 file changed

+6
-17
lines changed

nipype/pipeline/engine/utils.py

Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -364,23 +364,12 @@ def format_node(node, format="python", include_config=False):
364364
importline = "from %s import %s" % (klass.__module__, klass.__class__.__name__)
365365
comment = "# Node: %s" % node.fullname
366366
spec = signature(node.interface.__init__)
367-
args = [p.name for p in list(spec.parameters.values())]
368-
if args:
369-
filled_args = []
370-
for arg in args:
371-
if hasattr(node.interface, "_%s" % arg):
372-
argval = getattr(node.interface, "_%s" % arg)
373-
if isinstance(argval, str):
374-
filled_args.append(
375-
"%s='%s'" % (arg, argval)
376-
)
377-
else:
378-
filled_args.append(
379-
"%s=%s" % (arg, argval)
380-
)
381-
args = ", ".join(filled_args)
382-
else:
383-
args = ""
367+
filled_args = []
368+
for param in spec.parameters.values():
369+
val = getattr(node.interface, f"_{param.name}", None)
370+
if val is not None:
371+
filled_args.append(f"{param.name}={val!r}")
372+
args = ", ".join(filled_args)
384373
klass_name = klass.__class__.__name__
385374
if isinstance(node, MapNode):
386375
nodedef = '%s = MapNode(%s(%s), iterfield=%s, name="%s")' % (

0 commit comments

Comments
 (0)