Skip to content

Commit 1ea6198

Browse files
anonrigRafaelGSS
authored andcommitted
src: disallow copy/move fns/constructors
PR-URL: #56811 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Daniel Lemire <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
1 parent 14b2d49 commit 1ea6198

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

src/debug_utils-inl.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ struct ToStringHelper {
4949
template <unsigned BASE_BITS,
5050
typename T,
5151
typename = std::enable_if_t<!std::is_integral_v<T>>>
52-
static std::string BaseConvert(T value) {
52+
static std::string BaseConvert(T& value) { // NOLINT(runtime/references)
5353
return Convert(std::forward<T>(value));
5454
}
5555
};

src/util.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -387,6 +387,11 @@ constexpr size_t strsize(const T (&)[N]) {
387387
template <typename T, size_t kStackStorageSize = 1024>
388388
class MaybeStackBuffer {
389389
public:
390+
// Disallow copy constructor
391+
MaybeStackBuffer(const MaybeStackBuffer&) = delete;
392+
// Disallow copy assignment operator
393+
MaybeStackBuffer& operator=(const MaybeStackBuffer& other) = delete;
394+
390395
const T* out() const {
391396
return buf_;
392397
}

0 commit comments

Comments
 (0)