Skip to content

Commit 2aff6ff

Browse files
committed
src: enable Float16Array and explicit resource management
These features are enabled in stable Chrome 136 but not in V8 by default.
1 parent 5aad0a7 commit 2aff6ff

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

src/node.cc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -845,6 +845,11 @@ static ExitCode InitializeNodeWithArgsInternal(
845845
// is security relevant, for Node it's less important.
846846
V8::SetFlagsFromString("--no-freeze-flags-after-init");
847847

848+
// These features are completed and enabled by default in Chrome, but not
849+
// in V8.
850+
V8::SetFlagsFromString("--js-explicit-resource-management");
851+
V8::SetFlagsFromString("--js-float16array");
852+
848853
#if defined(NODE_V8_OPTIONS)
849854
// Should come before the call to V8::SetFlagsFromCommandLine()
850855
// so the user can disable a flag --foo at run-time by passing

test/common/globals.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ const intrinsics = new Set([
3333
'Int8Array',
3434
'Uint16Array',
3535
'Int16Array',
36+
'Float16Array',
3637
'Uint32Array',
3738
'Int32Array',
3839
'Float32Array',

test/wpt/status/encoding.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,12 +70,6 @@
7070
"requires": ["full-icu"]
7171
},
7272
"encodeInto.any.js": {
73-
"fail": {
74-
"expected": [
75-
"Invalid encodeInto() destination: Float16Array, backed by: ArrayBuffer",
76-
"Invalid encodeInto() destination: Float16Array, backed by: SharedArrayBuffer"
77-
]
78-
},
7973
"requires": ["small-icu"]
8074
},
8175
"textdecoder-copy.any.js": {

0 commit comments

Comments
 (0)