Skip to content

Commit 4daedf8

Browse files
committed
build: warn for GCC versions earlier than 12.2
Update the warning threshold for GCC to 12.2 starting from Node.js 23. Builds can still proceed with earlier versions of GCC, but are not guaranteed to work.
1 parent 027710e commit 4daedf8

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

BUILDING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ Depending on the host platform, the selection of toolchains may vary.
151151

152152
| Operating System | Compiler Versions |
153153
| ---------------- | -------------------------------------------------------------- |
154-
| Linux | GCC >= 10.1 |
154+
| Linux | GCC >= 12.2 |
155155
| Windows | Visual Studio >= 2022 with the Windows 10 SDK on a 64-bit host |
156156
| macOS | Xcode >= 13 (Apple LLVM >= 12) |
157157

@@ -230,7 +230,7 @@ The Node.js project supports Python >= 3 for building and testing.
230230

231231
#### Unix prerequisites
232232

233-
* `gcc` and `g++` >= 10.1 or newer
233+
* `gcc` and `g++` >= 12.2 or newer
234234
* GNU Make 3.81 or newer
235235
* [A supported version of Python][Python versions]
236236
* For test coverage, your Python installation must include pip.

configure.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1172,8 +1172,8 @@ def check_compiler(o):
11721172
print_verbose(f"Detected {'clang ' if is_clang else ''}C++ compiler (CXX={CXX}) version: {version_str}")
11731173
if not ok:
11741174
warn(f'failed to autodetect C++ compiler version (CXX={CXX})')
1175-
elif clang_version < (8, 0, 0) if is_clang else gcc_version < (10, 1, 0):
1176-
warn(f'C++ compiler (CXX={CXX}, {version_str}) too old, need g++ 10.1.0 or clang++ 8.0.0')
1175+
elif clang_version < (8, 0, 0) if is_clang else gcc_version < (12, 2, 0):
1176+
warn(f'C++ compiler (CXX={CXX}, {version_str}) too old, need g++ 12.2.0 or clang++ 8.0.0')
11771177

11781178
ok, is_clang, clang_version, gcc_version = try_check_compiler(CC, 'c')
11791179
version_str = ".".join(map(str, clang_version if is_clang else gcc_version))

0 commit comments

Comments
 (0)