Skip to content

Commit 61b9793

Browse files
committed
fully drain pending finalizers and support nested napi_ref deletion
1 parent 7ead6e2 commit 61b9793

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

test/js-native-api/6_object_wrap/6_object_wrap.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@ MyObject::MyObject(double value)
1111
: value_(value), env_(nullptr), wrapper_(nullptr), nested_(nullptr) {}
1212

1313
MyObject::~MyObject() {
14-
if (nested_ != nullptr) {
15-
napi_delete_reference(env_, nested_);
16-
}
14+
napi_delete_reference(env_, nested_);
1715
napi_delete_reference(env_, wrapper_);
1816
}
1917

@@ -79,6 +77,8 @@ napi_value MyObject::New(napi_env env, napi_callback_info info) {
7977
napi_wrap(env, _this, obj, MyObject::Destructor,
8078
nullptr /* finalize_hint */, &obj->wrapper_));
8179

80+
NODE_API_CALL(env, napi_create_reference(env, _this, 1, &obj->nested_));
81+
8282
return _this;
8383
}
8484

0 commit comments

Comments
 (0)