Skip to content

Commit 7e1f1a7

Browse files
committed
benchmark: update benchmark for URLSearchParams.sort
1 parent 3e14cfb commit 7e1f1a7

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

benchmark/url/url-searchparams-sort.js

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,30 +17,27 @@ const inputs = {
1717
};
1818

1919
function getParams(str) {
20-
const out = [];
21-
for (const key of str.split('&')) {
22-
out.push(key, '');
23-
}
24-
return out;
20+
return str.split('&');
2521
}
2622

2723
const bench = common.createBenchmark(main, {
2824
type: Object.keys(inputs),
2925
n: [1e6],
30-
}, {
31-
flags: ['--expose-internals'],
3226
});
3327

3428
function main({ type, n }) {
35-
const searchParams = require('internal/url').searchParamsSymbol;
3629
const input = inputs[type];
3730
const params = new URLSearchParams();
3831
const array = getParams(input);
3932

33+
for (let i = 0; i < array.length; i++) {
34+
params.append(array[i], '');
35+
}
36+
4037
bench.start();
4138
for (let i = 0; i < n; i++) {
42-
params[searchParams] = array.slice();
43-
params.sort();
39+
const paramsForSort = new URLSearchParams(params);
40+
paramsForSort.sort();
4441
}
4542
bench.end(n);
4643
}

0 commit comments

Comments
 (0)