Skip to content

Commit 8fa22ec

Browse files
committed
fixup! fixup! build: add create release proposal action
1 parent b6664a2 commit 8fa22ec

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

.github/workflows/create-release-proposal.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,6 @@ permissions:
2929

3030
jobs:
3131
env:
32-
STAGING_BRANCH: v${{ inputs.release-line }}.x-staging
33-
RELEASE_BRANCH: v${{ inputs.release-line }}.x
34-
RELEASE_DATE: ${{ inputs.release-date }}
3532
releasePrepare:
3633
runs-on: ubuntu-latest
3734
steps:
@@ -41,7 +38,6 @@ jobs:
4138
# Needs the whole git history for ncu to work
4239
# See https://github.com/nodejs/node-core-utils/pull/486
4340
fetch-depth: 0
44-
token: ${{ secrets.GH_USER_TOKEN }}
4541

4642
# Install dependencies
4743
- name: Install Node.js
@@ -56,10 +52,13 @@ jobs:
5652
run: |
5753
echo "REPOSITORY=$(echo ${{ github.repository }} | cut -d/ -f2)" >> $GITHUB_ENV
5854
echo "OWNER=${{ github.repository_owner }}" >> $GITHUB_ENV
55+
echo "STAGING_BRANCH=v${{ inputs.release-line }}.x-staging" >> $GITHUB_ENV
56+
echo "RELEASE_BRANCH=v${{ inputs.release-line }}.x" >> $GITHUB_ENV
57+
echo "RELEASE_DATE=${{ inputs.release-date }}" >> $GITHUB_ENV
5958
6059
- name: Configure @node-core/utils
6160
run: |
62-
ncu-config set branch ${{ env.RELEASE_BRANCH }}
61+
ncu-config set branch "${RELEASE_BRANCH}"
6362
ncu-config set upstream origin
6463
ncu-config set username "$USERNAME"
6564
ncu-config set token "$GH_TOKEN"
@@ -72,4 +71,5 @@ jobs:
7271
JENKINS_TOKEN: ${{ secrets.JENKINS_TOKEN }}
7372

7473
- name: Start git node release prepare
75-
run: ./tools/actions/create-release.sh ${{ inputs.RELEASE_DATE }}
74+
run: |
75+
./tools/actions/create-release.sh "${RELEASE_DATE}"

tools/actions/create-release.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ git node release --prepare --skipBranchDiff
88
# We use it to not specify the branch name as it changes based on
99
# the commit list (semver-minor/semver-patch)
1010
git config push.default current
11-
git push upstream
1211
echo "/## $RELEASE_DATE/,/^<a id=/{ if (!/^<a id=/) print }" > temp.awk
1312
awk -f temp.awk doc/changelogs/CHANGELOG_V23.md > pr-body.md
1413
gh pr create --body-file pr-body.md

0 commit comments

Comments
 (0)