Skip to content

Commit 95c8b00

Browse files
src: fix winapi_strerror error string
Fixes: #23191
1 parent d17fefc commit 95c8b00

File tree

2 files changed

+45
-2
lines changed

2 files changed

+45
-2
lines changed

src/api/exceptions.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,12 +157,12 @@ Local<Value> UVException(Isolate* isolate,
157157
static const char* winapi_strerror(const int errorno, bool* must_free) {
158158
char* errmsg = nullptr;
159159

160-
FormatMessage(FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM |
160+
FormatMessageA(FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM |
161161
FORMAT_MESSAGE_IGNORE_INSERTS,
162162
nullptr,
163163
errorno,
164164
MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT),
165-
reinterpret_cast<LPTSTR>(&errmsg),
165+
reinterpret_cast<LPSTR>(&errmsg),
166166
0,
167167
nullptr);
168168

test/parallel/test-print-GH-23191.js

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
// Copyright Joyent, Inc. and other Node contributors.
2+
//
3+
// Permission is hereby granted, free of charge, to any person obtaining a
4+
// copy of this software and associated documentation files (the
5+
// "Software"), to deal in the Software without restriction, including
6+
// without limitation the rights to use, copy, modify, merge, publish,
7+
// distribute, sublicense, and/or sell copies of the Software, and to permit
8+
// persons to whom the Software is furnished to do so, subject to the
9+
// following conditions:
10+
//
11+
// The above copyright notice and this permission notice shall be included
12+
// in all copies or substantial portions of the Software.
13+
//
14+
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
15+
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
16+
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
17+
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
18+
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
19+
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
20+
// USE OR OTHER DEALINGS IN THE SOFTWARE.
21+
22+
'use strict';
23+
const common = require('../common');
24+
const { strictEqual } = require('assert');
25+
26+
// Ref: https://github.com/nodejs/node/issues/23191
27+
// This test is specific to Windows.
28+
29+
async function testDebugPrint() {
30+
31+
const child = require('child_process');
32+
const cp = child.spawnSync(process.execPath,
33+
['-e', 'console.log("Hello World");']);
34+
try {
35+
process._debugProcess(cp.pid);
36+
} catch (error) {
37+
strictEqual(error.message, 'The parameter is incorrect.');
38+
}
39+
}
40+
41+
if (common.isWindows) {
42+
testDebugPrint().then(common.mustCall());
43+
}

0 commit comments

Comments
 (0)