Apply suggestions from code review

jasnell · anonrig · web-flow · commit cfda5801a81a · 2025-01-05T13:23:07.000-08:00
Co-authored-by: Yagiz Nizipli &lt;yagiz@nizipli.com&gt;
diff --git a/src/util-inl.h b/src/util-inl.h
@@ -181,7 +181,7 @@ inline v8::Local<v8::String> OneByteString(v8::Isolate* isolate,
 }
 
 inline v8::Local<v8::String> OneByteString(v8::Isolate* isolate,
-                                           const std::string_view& str) {
+                                           std::string_view str) {
   return OneByteString(isolate, str.data(), str.size());
 }
 
diff --git a/src/util.h b/src/util.h
@@ -341,7 +341,7 @@ inline v8::Local<v8::String> OneByteString(v8::Isolate* isolate,
                                            int length = -1);
 
 inline v8::Local<v8::String> OneByteString(v8::Isolate* isolate,
-                                           const std::string_view& str);
+                                           std::string_view str);
 
 // Used to be a macro, hence the uppercase name.
 template <int N>

Original file line number	Diff line number	Diff line change
`@@ -181,7 +181,7 @@ inline v8::Local<v8::String> OneByteString(v8::Isolate* isolate,`
`181`	`181`	`}`
`182`	`182`
`183`	`183`	`inline v8::Local<v8::String> OneByteString(v8::Isolate* isolate,`
`184`		`- const std::string_view& str) {`
	`184`	`+ std::string_view str) {`
`185`	`185`	`return OneByteString(isolate, str.data(), str.size());`
`186`	`186`	`}`
`187`	`187`