Skip to content

Commit d248639

Browse files
committed
src: use supported API to get stalled TLA messages
Refs: v8/v8@23e3b6f PR-URL: #51362 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
1 parent d34b02d commit d248639

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

src/module_wrap.cc

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -122,15 +122,15 @@ v8::Maybe<bool> ModuleWrap::CheckUnsettledTopLevelAwait() {
122122
if (!module->IsGraphAsync()) { // There is no TLA, no need to check.
123123
return v8::Just(true);
124124
}
125-
auto stalled = module->GetStalledTopLevelAwaitMessage(isolate);
126-
if (stalled.size() == 0) {
125+
126+
auto stalled_messages =
127+
std::get<1>(module->GetStalledTopLevelAwaitMessages(isolate));
128+
if (stalled_messages.size() == 0) {
127129
return v8::Just(true);
128130
}
129131

130132
if (env()->options()->warnings) {
131-
for (auto& pair : stalled) {
132-
Local<v8::Message> message = std::get<1>(pair);
133-
133+
for (auto& message : stalled_messages) {
134134
std::string reason = "Warning: Detected unsettled top-level await at ";
135135
std::string info =
136136
FormatErrorMessage(isolate, context, "", message, true);
@@ -614,11 +614,10 @@ void ModuleWrap::EvaluateSync(const FunctionCallbackInfo<Value>& args) {
614614

615615
if (module->IsGraphAsync()) {
616616
CHECK(env->options()->print_required_tla);
617-
auto stalled = module->GetStalledTopLevelAwaitMessage(isolate);
618-
if (stalled.size() != 0) {
619-
for (auto pair : stalled) {
620-
Local<v8::Message> message = std::get<1>(pair);
621-
617+
auto stalled_messages =
618+
std::get<1>(module->GetStalledTopLevelAwaitMessages(isolate));
619+
if (stalled_messages.size() != 0) {
620+
for (auto& message : stalled_messages) {
622621
std::string reason = "Error: unexpected top-level await at ";
623622
std::string info =
624623
FormatErrorMessage(isolate, context, "", message, true);

0 commit comments

Comments
 (0)