From 26a74edd17dfda3ec53109d96c17240d9d741e22 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=BCseyin=20A=C3=A7acak?= Date: Tue, 16 Jul 2024 09:22:40 +0300 Subject: [PATCH 1/2] build: avoid compiling with VS v17.10 Refs: https://github.com/nodejs/build/issues/3739 --- vcbuild.bat | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/vcbuild.bat b/vcbuild.bat index 95663cc9f59420..c460b9d21a9ce7 100644 --- a/vcbuild.bat +++ b/vcbuild.bat @@ -283,6 +283,14 @@ goto exit :msbuild-found +@rem Visual Studio v17.10 has a bug that causes the build to fail. +@rem Check if the version is v17.10 and exit if it is. +echo %VSCMD_VER% | findstr /b /c:"17.10" >nul +if %errorlevel% neq 1 ( + echo NodeJS doesn't compile with Visual Studio 17.10 Please use a different version. + goto exit +) + @rem check if the clang-cl build is requested if not defined clang_cl goto clang-skip @rem x64 is hard coded as it is used for both cross and native compilation. From 48ec7132d443eed224b1bc27e335f2656619af54 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=BCseyin=20A=C3=A7acak?= <110401522+huseyinacacak-janea@users.noreply.github.com> Date: Wed, 17 Jul 2024 08:22:46 +0300 Subject: [PATCH 2/2] Update vcbuild.bat Co-authored-by: Richard Lau --- vcbuild.bat | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vcbuild.bat b/vcbuild.bat index c460b9d21a9ce7..a2bed46dda65f0 100644 --- a/vcbuild.bat +++ b/vcbuild.bat @@ -287,7 +287,7 @@ goto exit @rem Check if the version is v17.10 and exit if it is. echo %VSCMD_VER% | findstr /b /c:"17.10" >nul if %errorlevel% neq 1 ( - echo NodeJS doesn't compile with Visual Studio 17.10 Please use a different version. + echo Node.js doesn't compile with Visual Studio 17.10 Please use a different version. goto exit )