Skip to content

Commit 2ed2a8a

Browse files
authored
add node v24 workflow (#4206)
* add node v24 workflow * fix http2 test * update wpt status
1 parent bf4c199 commit 2ed2a8a

File tree

4 files changed

+13
-8
lines changed

4 files changed

+13
-8
lines changed

.github/workflows/nodejs-shared.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
fail-fast: false
2020
max-parallel: 0
2121
matrix:
22-
version: [20, 22, 23]
22+
version: [20, 22, 24]
2323
runs-on: ubuntu-latest
2424
timeout-minutes: 120
2525
steps:

.github/workflows/nodejs.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ jobs:
5858
node-version:
5959
- 20
6060
- 22
61-
- 23
61+
- 24
6262
runs-on:
6363
- ubuntu-latest
6464
- windows-latest
@@ -75,7 +75,7 @@ jobs:
7575
fail-fast: false
7676
max-parallel: 0
7777
matrix:
78-
version: [20, 22, 23]
78+
version: [20, 22, 24]
7979
runs-on: ubuntu-latest
8080
timeout-minutes: 120
8181
steps:

test/http2.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1527,7 +1527,7 @@ test('#3046 - GOAWAY Frame', async t => {
15271527
t.strictEqual(response.headers['x-custom-h2'], 'hello')
15281528
t.strictEqual(response.statusCode, 200)
15291529

1530-
t.rejects(response.body.text(), {
1530+
await t.rejects(response.body.text(), {
15311531
message: 'HTTP/2: "GOAWAY" frame received with code 0',
15321532
code: 'UND_ERR_SOCKET'
15331533
})
@@ -1748,9 +1748,11 @@ test('Should handle http2 stream timeout', async t => {
17481748
body: stream
17491749
})
17501750

1751-
t.rejects(res.body.text(), {
1751+
await t.rejects(res.body.text(), {
17521752
message: 'HTTP/2: "stream timeout after 50"'
17531753
})
1754+
1755+
await t.completed
17541756
})
17551757

17561758
test('Should handle http2 trailers', async t => {

test/wpt/status/fetch.status.json

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,14 @@
5757
"skip": true
5858
},
5959
"request-headers.any.js": {
60+
"note": "Float16Array is valid from node v24.",
6061
"fail": [
6162
"Fetch with Chicken",
6263
"Fetch with Chicken with body",
6364
"Fetch with TacO and mode \"same-origin\" needs an Origin header",
64-
"Fetch with TacO and mode \"cors\" needs an Origin header",
65+
"Fetch with TacO and mode \"cors\" needs an Origin header"
66+
],
67+
"flaky": [
6568
"Fetch with POST with Float16Array body"
6669
]
6770
},
@@ -70,8 +73,8 @@
7073
"skip": true
7174
},
7275
"request-upload.any.js": {
73-
"note": "no Float16Array",
74-
"fail": [
76+
"note": "Float16Array is valid from node v24.",
77+
"flaky": [
7578
"Fetch with POST with Float16Array body"
7679
]
7780
},

0 commit comments

Comments
 (0)