Skip to content

Commit 6e97e3e

Browse files
committed
address review comments in the docs
1 parent 623f0d2 commit 6e97e3e

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

docs/content/customization/generic/global-mirror.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ If your registry mirror requires a private or self-signed CA certificate,
1717
create a Kubernetes Secret with the `ca.crt` key populated with the CA certificate in PEM format:
1818

1919
```shell
20-
kubectl create secret generic my-mirror-ca-cert-secret \
20+
kubectl create secret generic my-mirror-ca-cert \
2121
--from-file=ca.crt=registry-ca.crt
2222
```
2323

@@ -35,7 +35,7 @@ spec:
3535
url: https://my-mirror.io
3636
credentials:
3737
secretRef:
38-
name: my-mirror-ca-cert-secret
38+
name: my-mirror-ca-cert
3939
```
4040
4141
Applying this configuration will result in following new files on the

pkg/handlers/generic/mutation/mirrors/variables_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ func TestVariableValidation(t *testing.T) {
5252
ExpectError: true,
5353
},
5454
capitest.VariableTestDef{
55-
Name: "registry URL without http(s) format and path",
55+
Name: "mirror URL without format",
5656
Vals: v1alpha1.GenericClusterConfig{
5757
GlobalImageRegistryMirror: &v1alpha1.GlobalImageRegistryMirror{
5858
URL: "a.b.c.example.com/a/b/c",

0 commit comments

Comments
 (0)