[IMP] estate: add some sql and python constraints

Author: clom-odoo

estate/models/estate_properties.py

@@ -1,7 +1,8 @@
 
 from dateutil.relativedelta import relativedelta
 from odoo import fields, models, api
-from odoo.exceptions import UserError
+from odoo.exceptions import UserError, ValidationError
+from odoo.tools.float_utils import float_compare
 
 
 class Properties(models.Model):
@@ -45,6 +46,11 @@ class Properties(models.Model):
     total_area = fields.Float("Total Area", compute="_compute_area")
     best_price = fields.Float("Best Price", compute="_find_best_price")
 
+    _sql_constraints = [
+        ('positive_expecting_price', "CHECK(expected_price > 0)", "Property should have a strictly positive expected price !"),
+        ("positive_sell_price", "CHECK(selling_price > 0)", "Property should have a strictly positive selling price !"),
+        ]
+
     @api.depends("garden_area", "living_area")
     def _compute_area(self):
         for record in self:
@@ -79,3 +85,9 @@ def action_cancel(self):
             else:
                 raise UserError("Property is already sold")
         return True
+
+    @api.constrains("selling_price")
+    def _check_minimum_sell_price(self):
+        for a_property in self:
+            if float_compare(a_property.selling_price, a_property.expected_price * 0.9, 2) == -1:
+                raise ValidationError("The seling prce can not be lower than 90% of the expected price")

estate/models/estate_property_offer.py

@@ -14,6 +14,10 @@ class PropertyOffer(models.Model):
     date_deadline = fields.Date(default=fields.Date.today() + relativedelta(days=7), compute="_compute_deadline", inverse="_update_validity")
     validity = fields.Integer(default=7)
 
+    _sql_constraints = [
+        ("positive_offer_price", "CHECK(price > 0)", "Offer should have a strictly positive price !")
+    ]
+
     @api.depends("validity")
     def _compute_deadline(self):
         for record in self:

estate/models/estate_property_tag.py

@@ -6,3 +6,5 @@ class PropertyTags(models.Model):
     _description = "Tags used to describe a property"
 
     name = fields.Char("name", required=True)
+
+    _sql_constraints = [("unique_property_tag", "UNIQUE(name)", "Tag name must be unique !")]

estate/models/estate_property_type.py

@@ -6,3 +6,5 @@ class PropertyType(models.Model):
     _description = "the type of an estate"
 
     name = fields.Char("Type", required=True)
+
+    _sql_constraints = [("unique_property_tag", "UNIQUE(name)", "Tag name must be unique !")]