Skip to content

Commit aab3da6

Browse files
beldenonsi
belden
authored and
onsi
committed
Update tests
The trailing `""` to wrap empty labels was a CSV error. This commit simply updates the test files to be properly encoded. It is a result of running the updated `ginkgo` binary from the previous commit across all of the _testdata files. ---- There was prior art within `outline/outline.go` which tried to properly enclose a comma-separated list of labels within double quotes. This resulted in CSV output with trailing `""` characters for tests that have no labels. A trailing `""` is incorrect for CSV formatting. There are two special characters within CSV formatting: " 0x22 DOUBLE QUOTE , 0x2c COMMA The mechanism to embed the field-separator 0x2c within a string is to enclose it within quotation marks. The mechanism to embed the quotation mark within a string is to use two quotation marks. i.e. the following string: // go code foo := "The dog looked at me and said, \"Bark, bark!\"" should be represented in CSV as Punchline,Laughs "The dog looked at me and said, ""Bark, bark!""",17 just as it would be represnted in JSON as { "punchline": "The dog looked at me and said, \"Bark, bark!\"", "laughs": 17 }
1 parent c09df39 commit aab3da6

10 files changed

+137
-137
lines changed

‎ginkgo/outline/_testdata/alias_test.go.csv

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
Name,Text,Start,End,Spec,Focused,Pending,Labels
2-
Describe,NodotFixture,81,670,false,false,false,""
3-
Describe,normal,126,259,false,false,false,""
4-
It,normal,166,255,true,false,false,""
5-
By,normal,201,223,false,false,false,""
6-
By,normal,227,249,false,false,false,""
7-
Context,normal,262,342,false,false,false,""
8-
It,normal,301,338,true,false,false,""
9-
When,normal,345,422,false,false,false,""
10-
It,normal,381,418,true,false,false,""
11-
It,normal,425,461,true,false,false,""
12-
Specify,normal,464,505,true,false,false,""
13-
DescribeTable,normal,508,586,false,false,false,""
14-
Entry,normal,557,582,true,false,false,""
15-
DescribeTable,normal,589,667,false,false,false,""
16-
Entry,normal,638,663,true,false,false,""
2+
Describe,NodotFixture,81,670,false,false,false,
3+
Describe,normal,126,259,false,false,false,
4+
It,normal,166,255,true,false,false,
5+
By,normal,201,223,false,false,false,
6+
By,normal,227,249,false,false,false,
7+
Context,normal,262,342,false,false,false,
8+
It,normal,301,338,true,false,false,
9+
When,normal,345,422,false,false,false,
10+
It,normal,381,418,true,false,false,
11+
It,normal,425,461,true,false,false,
12+
Specify,normal,464,505,true,false,false,
13+
DescribeTable,normal,508,586,false,false,false,
14+
Entry,normal,557,582,true,false,false,
15+
DescribeTable,normal,589,667,false,false,false,
16+
Entry,normal,638,663,true,false,false,

‎ginkgo/outline/_testdata/dsl_core_test.go.csv

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Name,Text,Start,End,Spec,Focused,Pending,Labels
2-
Describe,DslCoreFixture,82,216,false,false,false,""
3-
Describe,dslcore,119,213,false,false,false,""
4-
It,dslcore,150,209,true,false,false,""
5-
By,step 1,176,188,false,false,false,""
6-
By,step 2,192,204,false,false,false,""
2+
Describe,DslCoreFixture,82,216,false,false,false,
3+
Describe,dslcore,119,213,false,false,false,
4+
It,dslcore,150,209,true,false,false,
5+
By,step 1,176,188,false,false,false,
6+
By,step 2,192,204,false,false,false,

‎ginkgo/outline/_testdata/focused_test.go.csv

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
Name,Text,Start,End,Spec,Focused,Pending,Labels
2-
Describe,unfocused,73,529,false,false,false,""
3-
FDescribe,focused,105,202,false,true,false,""
4-
It,focused,137,198,true,true,false,""
5-
By,focused,163,176,false,true,false,""
6-
By,focused,180,193,false,true,false,""
7-
FContext,focused,205,268,false,true,false,""
8-
It,focused,236,264,true,true,false,""
9-
FWhen,focused,271,331,false,true,false,""
10-
It,focused,299,327,true,true,false,""
11-
FIt,focused,334,362,true,true,false,""
12-
FSpecify,focused,365,398,true,true,false,""
13-
FDescribeTable,focused,401,462,false,true,false,""
14-
Entry,focused,442,458,true,true,false,""
15-
DescribeTable,focused,465,526,false,false,false,""
16-
FEntry,focused,505,522,true,true,false,""
2+
Describe,unfocused,73,529,false,false,false,
3+
FDescribe,focused,105,202,false,true,false,
4+
It,focused,137,198,true,true,false,
5+
By,focused,163,176,false,true,false,
6+
By,focused,180,193,false,true,false,
7+
FContext,focused,205,268,false,true,false,
8+
It,focused,236,264,true,true,false,
9+
FWhen,focused,271,331,false,true,false,
10+
It,focused,299,327,true,true,false,
11+
FIt,focused,334,362,true,true,false,
12+
FSpecify,focused,365,398,true,true,false,
13+
FDescribeTable,focused,401,462,false,true,false,
14+
Entry,focused,442,458,true,true,false,
15+
DescribeTable,focused,465,526,false,false,false,
16+
FEntry,focused,505,522,true,true,false,

‎ginkgo/outline/_testdata/labels_test.go.csv

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
Name,Text,Start,End,Spec,Focused,Pending,Labels
2-
Describe,NormalFixture,73,571,false,false,false,""
2+
Describe,NormalFixture,73,571,false,false,false,
33
Describe,normal,109,228,false,false,false,"normal, serial"
4-
It,normal,166,224,true,false,false,""
5-
By,step 1,191,203,false,false,false,""
6-
By,step 2,207,219,false,false,false,""
7-
Context,normal,231,323,false,false,false,""
4+
It,normal,166,224,true,false,false,
5+
By,step 1,191,203,false,false,false,
6+
By,step 2,207,219,false,false,false,
7+
Context,normal,231,323,false,false,false,
88
It,normal,260,319,true,false,false,"medium, slow"
9-
When,normal,326,383,false,false,false,""
10-
It,normal,352,379,true,false,false,""
11-
It,normal,386,412,true,false,false,""
12-
Specify,normal,415,446,true,false,false,""
13-
DescribeTable,normal,449,507,false,false,false,""
14-
Entry,normal,488,503,true,false,false,""
15-
DescribeTable,normal,510,568,false,false,false,""
16-
Entry,normal,549,564,true,false,false,""
9+
When,normal,326,383,false,false,false,
10+
It,normal,352,379,true,false,false,
11+
It,normal,386,412,true,false,false,
12+
Specify,normal,415,446,true,false,false,
13+
DescribeTable,normal,449,507,false,false,false,
14+
Entry,normal,488,503,true,false,false,
15+
DescribeTable,normal,510,568,false,false,false,
16+
Entry,normal,549,564,true,false,false,

‎ginkgo/outline/_testdata/mixed_test.go.csv

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
Name,Text,Start,End,Spec,Focused,Pending,Labels
2-
FDescribe,unfocused,73,584,false,false,false,""
3-
FContext,unfocused,106,205,false,false,false,""
4-
It,unfocused,139,169,true,false,false,""
5-
FIt,focused,172,201,true,true,false,""
6-
Context,unfocused,208,306,false,false,false,""
7-
FIt,focused,240,269,true,true,false,""
8-
It,unfocused,272,302,true,false,false,""
9-
FContext,focused,309,403,false,true,false,""
10-
It,focused,340,368,true,true,false,""
11-
It,focused,371,399,true,true,false,""
12-
PContext,unfocused,406,581,false,false,true,""
13-
FIt,unfocused,439,507,true,false,true,""
14-
By,unfocused,468,483,false,false,true,""
15-
By,unfocused,487,502,false,false,true,""
16-
It,unfocused,510,577,true,false,true,""
17-
By,unfocused,538,553,false,false,true,""
18-
By,unfocused,557,572,false,false,true,""
2+
FDescribe,unfocused,73,584,false,false,false,
3+
FContext,unfocused,106,205,false,false,false,
4+
It,unfocused,139,169,true,false,false,
5+
FIt,focused,172,201,true,true,false,
6+
Context,unfocused,208,306,false,false,false,
7+
FIt,focused,240,269,true,true,false,
8+
It,unfocused,272,302,true,false,false,
9+
FContext,focused,309,403,false,true,false,
10+
It,focused,340,368,true,true,false,
11+
It,focused,371,399,true,true,false,
12+
PContext,unfocused,406,581,false,false,true,
13+
FIt,unfocused,439,507,true,false,true,
14+
By,unfocused,468,483,false,false,true,
15+
By,unfocused,487,502,false,false,true,
16+
It,unfocused,510,577,true,false,true,
17+
By,unfocused,538,553,false,false,true,
18+
By,unfocused,557,572,false,false,true,

‎ginkgo/outline/_testdata/nestedfocused_test.go.csv

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
Name,Text,Start,End,Spec,Focused,Pending,Labels
2-
FDescribe,unfocused,73,476,false,false,false,""
3-
FContext,unfocused,106,275,false,false,false,""
4-
It,unfocused,139,206,true,false,false,""
5-
By,unfocused,167,182,false,false,false,""
6-
By,unfocused,186,201,false,false,false,""
7-
FIt,focused,209,271,true,true,false,""
8-
By,focused,236,249,false,true,false,""
9-
By,focused,253,266,false,true,false,""
10-
Context,unfocused,278,376,false,false,false,""
11-
FIt,focused,310,339,true,true,false,""
12-
It,unfocused,342,372,true,false,false,""
13-
FContext,focused,379,473,false,true,false,""
14-
It,focused,410,438,true,true,false,""
15-
It,focused,441,469,true,true,false,""
2+
FDescribe,unfocused,73,476,false,false,false,
3+
FContext,unfocused,106,275,false,false,false,
4+
It,unfocused,139,206,true,false,false,
5+
By,unfocused,167,182,false,false,false,
6+
By,unfocused,186,201,false,false,false,
7+
FIt,focused,209,271,true,true,false,
8+
By,focused,236,249,false,true,false,
9+
By,focused,253,266,false,true,false,
10+
Context,unfocused,278,376,false,false,false,
11+
FIt,focused,310,339,true,true,false,
12+
It,unfocused,342,372,true,false,false,
13+
FContext,focused,379,473,false,true,false,
14+
It,focused,410,438,true,true,false,
15+
It,focused,441,469,true,true,false,

‎ginkgo/outline/_testdata/nodot_test.go.csv

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
Name,Text,Start,End,Spec,Focused,Pending,Labels
2-
Describe,NodotFixture,71,614,false,false,false,""
3-
Describe,normal,113,233,false,false,false,""
4-
It,normal,150,229,true,false,false,""
5-
By,normal,182,201,false,false,false,""
6-
By,normal,205,224,false,false,false,""
7-
Context,normal,236,310,false,false,false,""
8-
It,normal,272,306,true,false,false,""
9-
When,normal,313,384,false,false,false,""
10-
It,normal,346,380,true,false,false,""
11-
It,normal,387,420,true,false,false,""
12-
Specify,normal,423,461,true,false,false,""
13-
DescribeTable,normal,464,536,false,false,false,""
14-
Entry,normal,510,532,true,false,false,""
15-
DescribeTable,normal,539,611,false,false,false,""
16-
Entry,normal,585,607,true,false,false,""
2+
Describe,NodotFixture,71,614,false,false,false,
3+
Describe,normal,113,233,false,false,false,
4+
It,normal,150,229,true,false,false,
5+
By,normal,182,201,false,false,false,
6+
By,normal,205,224,false,false,false,
7+
Context,normal,236,310,false,false,false,
8+
It,normal,272,306,true,false,false,
9+
When,normal,313,384,false,false,false,
10+
It,normal,346,380,true,false,false,
11+
It,normal,387,420,true,false,false,
12+
Specify,normal,423,461,true,false,false,
13+
DescribeTable,normal,464,536,false,false,false,
14+
Entry,normal,510,532,true,false,false,
15+
DescribeTable,normal,539,611,false,false,false,
16+
Entry,normal,585,607,true,false,false,

‎ginkgo/outline/_testdata/normal_test.go.csv

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
Name,Text,Start,End,Spec,Focused,Pending,Labels
2-
Describe,NormalFixture,73,512,false,false,false,""
3-
Describe,normal,109,201,false,false,false,""
4-
It,normal,139,197,true,false,false,""
5-
By,step 1,164,176,false,false,false,""
6-
By,step 2,180,192,false,false,false,""
7-
Context,normal,204,264,false,false,false,""
8-
It,normal,233,260,true,false,false,""
9-
When,normal,267,324,false,false,false,""
10-
It,normal,293,320,true,false,false,""
11-
It,normal,327,353,true,false,false,""
12-
Specify,normal,356,387,true,false,false,""
13-
DescribeTable,normal,390,448,false,false,false,""
14-
Entry,normal,429,444,true,false,false,""
15-
DescribeTable,normal,451,509,false,false,false,""
16-
Entry,normal,490,505,true,false,false,""
2+
Describe,NormalFixture,73,512,false,false,false,
3+
Describe,normal,109,201,false,false,false,
4+
It,normal,139,197,true,false,false,
5+
By,step 1,164,176,false,false,false,
6+
By,step 2,180,192,false,false,false,
7+
Context,normal,204,264,false,false,false,
8+
It,normal,233,260,true,false,false,
9+
When,normal,267,324,false,false,false,
10+
It,normal,293,320,true,false,false,
11+
It,normal,327,353,true,false,false,
12+
Specify,normal,356,387,true,false,false,
13+
DescribeTable,normal,390,448,false,false,false,
14+
Entry,normal,429,444,true,false,false,
15+
DescribeTable,normal,451,509,false,false,false,
16+
Entry,normal,490,505,true,false,false,

‎ginkgo/outline/_testdata/pending_decorator_test.go.csv

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
Name,Text,Start,End,Spec,Focused,Pending,Labels
2-
Describe,NormalFixture,73,591,false,false,false,""
2+
Describe,NormalFixture,73,591,false,false,false,
33
Describe,normal,109,237,false,false,true,"normal, serial"
4-
It,normal,175,233,true,false,true,""
5-
By,step 1,200,212,false,false,true,""
6-
By,step 2,216,228,false,false,true,""
7-
Context,normal,240,332,false,false,false,""
4+
It,normal,175,233,true,false,true,
5+
By,step 1,200,212,false,false,true,
6+
By,step 2,216,228,false,false,true,
7+
Context,normal,240,332,false,false,false,
88
It,normal,269,328,true,false,false,"medium, slow"
9-
When,normal,335,392,false,false,false,""
10-
It,normal,361,388,true,false,false,""
11-
It,normal,395,432,true,false,true,""
12-
Specify,normal,435,466,true,false,false,""
13-
DescribeTable,normal,469,527,false,false,false,""
14-
Entry,normal,508,523,true,false,false,""
15-
DescribeTable,normal,530,588,false,false,false,""
16-
Entry,normal,569,584,true,false,false,""
9+
When,normal,335,392,false,false,false,
10+
It,normal,361,388,true,false,false,
11+
It,normal,395,432,true,false,true,
12+
Specify,normal,435,466,true,false,false,
13+
DescribeTable,normal,469,527,false,false,false,
14+
Entry,normal,508,523,true,false,false,
15+
DescribeTable,normal,530,588,false,false,false,
16+
Entry,normal,569,584,true,false,false,

‎ginkgo/outline/_testdata/pending_test.go.csv

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
Name,Text,Start,End,Spec,Focused,Pending,Labels
2-
Describe,PendingFixture,73,534,false,false,false,""
3-
PDescribe,pending,110,207,false,false,true,""
4-
It,pending,142,203,true,false,true,""
5-
By,pending,168,181,false,false,true,""
6-
By,pending,185,198,false,false,true,""
7-
PContext,pending,210,273,false,false,true,""
8-
It,pending,241,269,true,false,true,""
9-
PWhen,pending,276,336,false,false,true,""
10-
It,pending,304,332,true,false,true,""
11-
PIt,pending,339,367,true,false,true,""
12-
PSpecify,pending,370,403,true,false,true,""
13-
PDescribeTable,pending,406,467,false,false,true,""
14-
Entry,pending,447,463,true,false,true,""
15-
DescribeTable,pending,470,531,false,false,false,""
16-
PEntry,pending,510,527,true,false,true,""
2+
Describe,PendingFixture,73,534,false,false,false,
3+
PDescribe,pending,110,207,false,false,true,
4+
It,pending,142,203,true,false,true,
5+
By,pending,168,181,false,false,true,
6+
By,pending,185,198,false,false,true,
7+
PContext,pending,210,273,false,false,true,
8+
It,pending,241,269,true,false,true,
9+
PWhen,pending,276,336,false,false,true,
10+
It,pending,304,332,true,false,true,
11+
PIt,pending,339,367,true,false,true,
12+
PSpecify,pending,370,403,true,false,true,
13+
PDescribeTable,pending,406,467,false,false,true,
14+
Entry,pending,447,463,true,false,true,
15+
DescribeTable,pending,470,531,false,false,false,
16+
PEntry,pending,510,527,true,false,true,

0 commit comments

Comments
 (0)