osc/rdma: fix bug introduced in b90c838

hjelmn · hjelmn · commit fc64d7749a47 · 2018-07-10T18:18:44.000-06:00
This commit fixes an bug that was introduced back in 2016 which impacts request-based RMA in some cases. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> (cherry picked from commit 037656b) Signed-off-by: Nathan Hjelm <hjelmn@me.com>
diff --git a/ompi/mca/osc/rdma/osc_rdma_request.c b/ompi/mca/osc/rdma/osc_rdma_request.c
@@ -33,7 +33,7 @@ static int request_free(struct ompi_request_t **ompi_req)
     ompi_osc_rdma_request_t *request =
         (ompi_osc_rdma_request_t*) *ompi_req;
 
-    if( REQUEST_COMPLETE(&request->super) ) {
+    if (!REQUEST_COMPLETE(&request->super)) {
         return MPI_ERR_REQUEST;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ static int request_free(struct ompi_request_t **ompi_req)`
`33`	`33`	`ompi_osc_rdma_request_t *request =`
`34`	`34`	`(ompi_osc_rdma_request_t) ompi_req;`
`35`	`35`
`36`		`- if( REQUEST_COMPLETE(&request->super) ) {`
	`36`	`+ if (!REQUEST_COMPLETE(&request->super)) {`
`37`	`37`	`return MPI_ERR_REQUEST;`
`38`	`38`	`}`
`39`	`39`