Skip to content

Commit 33a75d0

Browse files
authored
Fixed debug field usage in zipkin exporter (#549)
Zipkin spec expects the debug field to be a boolean, not an integer.
1 parent aea6530 commit 33a75d0

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

ext/opentelemetry-ext-zipkin/src/opentelemetry/ext/zipkin/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ def _translate_to_zipkin(self, spans: Sequence[Span]):
180180
}
181181

182182
if context.trace_flags.sampled:
183-
zipkin_span["debug"] = 1
183+
zipkin_span["debug"] = True
184184

185185
if isinstance(span.parent, Span):
186186
zipkin_span["parentId"] = format(

ext/opentelemetry-ext-zipkin/tests/test_zipkin_exporter.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ def test_export(self):
197197
"value": "event0",
198198
}
199199
],
200-
"debug": 1,
200+
"debug": True,
201201
"parentId": format(parent_id, "x"),
202202
},
203203
{

0 commit comments

Comments
 (0)