Skip to content

Commit 4a9ba6b

Browse files
committed
Remove configuration file from manager
1 parent cfd6d3e commit 4a9ba6b

File tree

4 files changed

+2
-73
lines changed

4 files changed

+2
-73
lines changed

opentelemetry-api/src/opentelemetry/configuration/__init__.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,8 @@
2525
powerful one, Dynaconf, for example.
2626
"""
2727

28-
from json import load
2928
from logging import getLogger
3029
from os import environ
31-
from os.path import exists, expanduser, join
3230

3331
from pkg_resources import iter_entry_points
3432

@@ -47,18 +45,6 @@ def __new__(cls) -> "Configuration":
4745
key: "default_{}".format(key) for key in cls.__slots__
4846
}
4947

50-
configuration_file_path = join(
51-
expanduser("~"), ".config", "opentelemetry_python.json"
52-
)
53-
54-
if exists(configuration_file_path):
55-
56-
with open(configuration_file_path) as configuration_file:
57-
file_configuration = load(configuration_file)
58-
59-
for key, value in configuration.items():
60-
configuration[key] = file_configuration.get(key, value)
61-
6248
for key, value in configuration.items():
6349
configuration[key] = environ.get(
6450
"OPENTELEMETRY_PYTHON_{}".format(key.upper()), value

opentelemetry-api/src/opentelemetry/configuration/opentelemetry_python.json

Lines changed: 0 additions & 4 deletions
This file was deleted.

opentelemetry-api/tests/configuration/test_configuration.py

Lines changed: 0 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
# limitations under the License.
1414

1515
from json import dumps
16-
from os import getcwd
1716
from unittest import TestCase
1817
from unittest.mock import patch
1918

@@ -87,25 +86,6 @@ def test_default_values( # type: ignore
8786
Configuration().meter_provider, "default_meter_provider"
8887
) # pylint: disable=no-member
8988

90-
@patch(
91-
"opentelemetry.configuration.iter_entry_points",
92-
**{"side_effect": IterEntryPointsMock} # type: ignore
93-
)
94-
@patch("opentelemetry.configuration.expanduser")
95-
def test_configuration_file( # type: ignore
96-
self,
97-
mock_expanduser,
98-
mock_iter_entry_points, # pylint: disable=unused-argument
99-
): # type: ignore
100-
mock_expanduser.return_value = getcwd()
101-
102-
self.assertEqual(
103-
Configuration().tracer_provider, "overridden_tracer_provider"
104-
) # pylint: disable=no-member
105-
self.assertEqual(
106-
Configuration().meter_provider, "default_meter_provider"
107-
) # pylint: disable=no-member
108-
10989
@patch(
11090
"opentelemetry.configuration.iter_entry_points",
11191
**{"side_effect": IterEntryPointsMock} # type: ignore
@@ -124,33 +104,6 @@ def test_environment_variables( # type: ignore
124104
Configuration().meter_provider, "overridden_meter_provider"
125105
) # pylint: disable=no-member
126106

127-
@patch(
128-
"opentelemetry.configuration.iter_entry_points",
129-
**{"side_effect": IterEntryPointsMock} # type: ignore
130-
)
131-
@patch("opentelemetry.configuration.expanduser")
132-
@patch.dict(
133-
"os.environ",
134-
{
135-
"OPENTELEMETRY_PYTHON_TRACER_PROVIDER": (
136-
"reoverridden_tracer_provider"
137-
)
138-
},
139-
)
140-
def test_configuration_file_environment_variables( # type: ignore
141-
self,
142-
mock_expanduser,
143-
mock_iter_entry_points, # pylint: disable=unused-argument
144-
): # type: ignore
145-
mock_expanduser.return_value = getcwd()
146-
147-
self.assertEqual(
148-
Configuration().tracer_provider, "reoverridden_tracer_provider"
149-
)
150-
self.assertEqual(
151-
Configuration().meter_provider, "default_meter_provider"
152-
)
153-
154107
def test_property(self):
155108
with self.assertRaises(AttributeError):
156109
Configuration().tracer_provider = "new_tracer_provider"

tests/w3c_tracecontext_validation_server.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,22 +19,15 @@
1919
"""
2020

2121
import json
22-
from os import environ
2322

2423
import flask
2524
import requests
2625

2726
# FIXME This could likely be avoided by integrating this script into the
2827
# standard test running mechanisms.
2928

30-
environ[
31-
"OPENTELEMETRY_PYTHON_TRACER_PROVIDER"
32-
] = "sdk_tracer_provider" # isort:skip
33-
environ[
34-
"OPENTELEMETRY_PYTHON_METER_PROVIDER"
35-
] = "sdk_meter_provider" # isort:skip
36-
3729
from opentelemetry import trace # noqa # isort:skip
30+
from opentelemetry.sdk.trace import TracerProvider
3831
from opentelemetry.ext import http_requests # noqa # isort:skip"
3932
from opentelemetry.ext.wsgi import OpenTelemetryMiddleware # noqa # isort:skip
4033
from opentelemetry.sdk.trace.export import ( # noqa # isort:skip
@@ -45,6 +38,7 @@
4538
# Integrations are the glue that binds the OpenTelemetry API and the
4639
# frameworks and libraries that are used together, automatically creating
4740
# Spans and propagating context as appropriate.
41+
trace.set_tracer_provider(TracerProvider())
4842
http_requests.enable(trace.get_tracer_provider())
4943

5044
# SpanExporter receives the spans and send them to the target location.

0 commit comments

Comments
 (0)