Skip to content

Commit 698a68b

Browse files
committed
Revert b3_format.py
1 parent 6a2c5e7 commit 698a68b

File tree

1 file changed

+2
-25
lines changed
  • opentelemetry-sdk/src/opentelemetry/sdk/context/propagation

1 file changed

+2
-25
lines changed

opentelemetry-sdk/src/opentelemetry/sdk/context/propagation/b3_format.py

Lines changed: 2 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ class B3Format(HTTPTextFormat):
2727
SINGLE_HEADER_KEY = "b3"
2828
TRACE_ID_KEY = "x-b3-traceid"
2929
SPAN_ID_KEY = "x-b3-spanid"
30-
PARENT_SPAN_ID_KEY = "x-b3-parentspanid"
3130
SAMPLED_KEY = "x-b3-sampled"
3231
FLAGS_KEY = "x-b3-flags"
3332
_SAMPLE_PROPAGATE_VALUES = set(["1", "True", "true", "d"])
@@ -36,7 +35,6 @@ class B3Format(HTTPTextFormat):
3635
def extract(cls, get_from_carrier, carrier):
3736
trace_id = format_trace_id(trace.INVALID_TRACE_ID)
3837
span_id = format_span_id(trace.INVALID_SPAN_ID)
39-
parent_span_id = format_span_id(trace.INVALID_SPAN_ID)
4038
sampled = "0"
4139
flags = None
4240

@@ -57,7 +55,7 @@ def extract(cls, get_from_carrier, carrier):
5755
elif len(fields) == 3:
5856
trace_id, span_id, sampled = fields
5957
elif len(fields) == 4:
60-
trace_id, span_id, sampled, parent_span_id = fields
58+
trace_id, span_id, sampled, _parent_span_id = fields
6159
else:
6260
return trace.INVALID_SPAN_CONTEXT
6361
else:
@@ -73,12 +71,6 @@ def extract(cls, get_from_carrier, carrier):
7371
)
7472
or span_id
7573
)
76-
parent_span_id = (
77-
_extract_first_element(
78-
get_from_carrier(carrier, cls.PARENT_SPAN_ID_KEY)
79-
)
80-
or parent_span_id
81-
)
8274
sampled = (
8375
_extract_first_element(
8476
get_from_carrier(carrier, cls.SAMPLED_KEY)
@@ -99,22 +91,12 @@ def extract(cls, get_from_carrier, carrier):
9991
# header is set to allow.
10092
if sampled in cls._SAMPLE_PROPAGATE_VALUES or flags == "1":
10193
options |= trace.TraceOptions.SAMPLED
102-
103-
trace_state = trace.TraceState()
104-
105-
if parent_span_id != trace.INVALID_SPAN_ID:
106-
# FIXME This is a workaround for the error specified below being
107-
# raised because of a pylint issue. Remove this when the issue is
108-
# fixed in pylint.
109-
# pylint: disable=E1137
110-
trace_state[cls.PARENT_SPAN_ID_KEY] = int(parent_span_id, 16)
111-
11294
return trace.SpanContext(
11395
# trace an span ids are encoded in hex, so must be converted
11496
trace_id=int(trace_id, 16),
11597
span_id=int(span_id, 16),
11698
trace_options=trace.TraceOptions(options),
117-
trace_state=trace_state,
99+
trace_state=trace.TraceState(),
118100
)
119101

120102
@classmethod
@@ -126,11 +108,6 @@ def inject(cls, context, set_in_carrier, carrier):
126108
set_in_carrier(
127109
carrier, cls.SPAN_ID_KEY, format_span_id(context.span_id)
128110
)
129-
set_in_carrier(
130-
carrier,
131-
cls.PARENT_SPAN_ID_KEY,
132-
format_span_id(context.trace_state[cls.PARENT_SPAN_ID_KEY]),
133-
)
134111
set_in_carrier(carrier, cls.SAMPLED_KEY, "1" if sampled else "0")
135112

136113

0 commit comments

Comments
 (0)