Skip to content

Commit fbbba1f

Browse files
owaisNathanielRN
andcommitted
Update instrumentation/opentelemetry-instrumentation-tornado/tests/test_instrumentation.py
Co-authored-by: (Eliseo) Nathaniel Ruiz Nowell <[email protected]>
1 parent 65b2d19 commit fbbba1f

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

instrumentation/opentelemetry-instrumentation-tornado/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
## Unreleased
44

5+
- Added support for `OTEL_PYTHON_TORNADO_TRACED_REQUEST_ATTRS` ([#1178](https://github.com/open-telemetry/opentelemetry-python/pull/1178))
6+
57
## Version 0.13b0
68

79
Released 2020-09-17

instrumentation/opentelemetry-instrumentation-tornado/README.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ For example,
4040

4141
::
4242

43-
export OTEL_PYTHON_TONADO_TRACED_REQUEST_ATTRS='uri,query'
43+
export OTEL_PYTHON_TORNADO_TRACED_REQUEST_ATTRS='uri,query'
4444

4545
will extract path_info and content_type attributes from every traced request and add them as span attributes.
4646

instrumentation/opentelemetry-instrumentation-tornado/tests/test_instrumentation.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -347,10 +347,10 @@ def test_traced_attrs(self):
347347
self.fetch("/ping?q=abc&b=123")
348348
spans = self.sorted_spans(self.memory_exporter.get_finished_spans())
349349
self.assertEqual(len(spans), 2)
350-
server = spans[0]
351-
self.assertEqual(server.kind, SpanKind.SERVER)
350+
server_span = spans[0]
351+
self.assertEqual(server_span.kind, SpanKind.SERVER)
352352
self.assert_span_has_attributes(
353-
server, {"uri": "/ping?q=abc&b=123", "query": "q=abc&b=123"}
353+
server_span, {"uri": "/ping?q=abc&b=123", "query": "q=abc&b=123"}
354354
)
355355
self.memory_exporter.clear()
356356

0 commit comments

Comments
 (0)