diff --git a/.pylintrc b/.pylintrc index 1aa1e10d0b4..84210f2c751 100644 --- a/.pylintrc +++ b/.pylintrc @@ -229,7 +229,7 @@ dummy-variables-rgx=_+$|(_[a-zA-Z0-9_]*[a-zA-Z0-9]+?$)|dummy|^ignored_|^unused_ ignored-argument-names=_.*|^ignored_|^unused_ # Tells whether we should check for unused import in __init__ files. -init-import=no +init-import=yes # List of qualified module names which can have objects that can redefine # builtins. diff --git a/ext/opentelemetry-ext-prometheus/src/opentelemetry/ext/prometheus/__init__.py b/ext/opentelemetry-ext-prometheus/src/opentelemetry/ext/prometheus/__init__.py index 5b4a17a5569..36397e50977 100644 --- a/ext/opentelemetry-ext-prometheus/src/opentelemetry/ext/prometheus/__init__.py +++ b/ext/opentelemetry-ext-prometheus/src/opentelemetry/ext/prometheus/__init__.py @@ -19,16 +19,14 @@ import re from typing import Sequence -from prometheus_client import start_http_server from prometheus_client.core import ( REGISTRY, - CollectorRegistry, CounterMetricFamily, GaugeMetricFamily, UnknownMetricFamily, ) -from opentelemetry.metrics import Counter, Gauge, Measure, Metric +from opentelemetry.metrics import Counter, Gauge, Measure from opentelemetry.sdk.metrics.export import ( MetricRecord, MetricsExporter, diff --git a/ext/opentelemetry-ext-psycopg2/src/opentelemetry/ext/psycopg2/__init__.py b/ext/opentelemetry-ext-psycopg2/src/opentelemetry/ext/psycopg2/__init__.py index 41816884892..f0a0a3e8882 100644 --- a/ext/opentelemetry-ext-psycopg2/src/opentelemetry/ext/psycopg2/__init__.py +++ b/ext/opentelemetry-ext-psycopg2/src/opentelemetry/ext/psycopg2/__init__.py @@ -13,8 +13,8 @@ # limitations under the License. """ -The opentelemetry-ext-psycopg2 package allows tracing PostgreSQL queries made by the -Psycopg2 library. +The opentelemetry-ext-psycopg2 package allows tracing PostgreSQL queries made +by the Psycopg2 library. """ import logging @@ -25,7 +25,6 @@ from psycopg2.sql import Composable from opentelemetry.ext.dbapi import DatabaseApiIntegration, TracedCursor -from opentelemetry.trace import Tracer logger = logging.getLogger(__name__) diff --git a/opentelemetry-api/src/opentelemetry/context/__init__.py b/opentelemetry-api/src/opentelemetry/context/__init__.py index 1d1b53e7cb2..e098db7dbc2 100644 --- a/opentelemetry-api/src/opentelemetry/context/__init__.py +++ b/opentelemetry-api/src/opentelemetry/context/__init__.py @@ -19,6 +19,7 @@ from pkg_resources import iter_entry_points +# pylint: disable=unused-import from opentelemetry.context.context import Context, RuntimeContext logger = logging.getLogger(__name__) diff --git a/opentelemetry-api/src/opentelemetry/trace/propagation/__init__.py b/opentelemetry-api/src/opentelemetry/trace/propagation/__init__.py index 881a74287a2..d85519eb352 100644 --- a/opentelemetry-api/src/opentelemetry/trace/propagation/__init__.py +++ b/opentelemetry-api/src/opentelemetry/trace/propagation/__init__.py @@ -11,9 +11,6 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. -from typing import Optional - -from opentelemetry.trace import INVALID_SPAN_CONTEXT, Span, SpanContext _SPAN_CONTEXT_KEY = "extracted-span-context" SPAN_KEY = "current-span" diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/distributedcontext/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/distributedcontext/__init__.py index 7a0a66a8a9a..4de1cfd8d9a 100644 --- a/opentelemetry-sdk/src/opentelemetry/sdk/distributedcontext/__init__.py +++ b/opentelemetry-sdk/src/opentelemetry/sdk/distributedcontext/__init__.py @@ -16,7 +16,7 @@ from contextlib import contextmanager from opentelemetry import distributedcontext as dctx_api -from opentelemetry.context import Context, get_value, set_value +from opentelemetry.context import Context from opentelemetry.distributedcontext import ( distributed_context_from_context, with_distributed_context, diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py index 4c9231582c8..300d87ab5d1 100644 --- a/opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py +++ b/opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py @@ -13,7 +13,6 @@ # limitations under the License. import logging -from collections import OrderedDict from typing import Dict, Sequence, Tuple, Type from opentelemetry import metrics as metrics_api diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/metrics/export/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/metrics/export/__init__.py index 6901a4efe46..f885ebfb52a 100644 --- a/opentelemetry-sdk/src/opentelemetry/sdk/metrics/export/__init__.py +++ b/opentelemetry-sdk/src/opentelemetry/sdk/metrics/export/__init__.py @@ -13,7 +13,7 @@ # limitations under the License. from enum import Enum -from typing import Sequence, Tuple +from typing import Sequence class MetricsExportResult(Enum): diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py index 7ce0ea3a836..99330c39eca 100644 --- a/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py +++ b/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py @@ -26,7 +26,7 @@ from opentelemetry import trace as trace_api from opentelemetry.sdk import util from opentelemetry.sdk.util import BoundedDict, BoundedList -from opentelemetry.trace import SpanContext, sampling +from opentelemetry.trace import sampling from opentelemetry.trace.propagation import SPAN_KEY from opentelemetry.trace.status import Status, StatusCanonicalCode from opentelemetry.util import time_ns, types