Skip to content

Commit 8f9c327

Browse files
author
Matthew Shapiro
committed
Added missint sort, and unstable sorts
1 parent 36a9aab commit 8f9c327

File tree

1 file changed

+3
-2
lines changed
  • opentelemetry-sdk/src/attributes

1 file changed

+3
-2
lines changed

opentelemetry-sdk/src/attributes/set.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ impl From<&[KeyValue]> for AttributeSet {
122122
}
123123
})
124124
.collect::<Vec<_>>();
125-
vec.sort();
125+
vec.sort_unstable();
126126

127127
let mut hasher = DefaultHasher::new();
128128
for value in &vec {
@@ -135,10 +135,11 @@ impl From<&[KeyValue]> for AttributeSet {
135135

136136
impl From<&Resource> for AttributeSet {
137137
fn from(values: &Resource) -> Self {
138-
let vec = values
138+
let mut vec = values
139139
.iter()
140140
.map(|(key, value)| HashKeyValue(KeyValue::new(key.clone(), value.clone())))
141141
.collect::<Vec<_>>();
142+
vec.sort_unstable();
142143

143144
let mut hasher = DefaultHasher::new();
144145
for value in &vec {

0 commit comments

Comments
 (0)