Skip to content

Implement submodule changes showing in PR #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
YoukouTenhouin opened this issue Nov 13, 2024 · 2 comments
Closed

Implement submodule changes showing in PR #68

YoukouTenhouin opened this issue Nov 13, 2024 · 2 comments
Assignees
@YoukouTenhouin
Labels
gitea UI feature
Milestone
after 1st release

Comments

@YoukouTenhouin
Copy link
Collaborator

Background: go-gitea/gitea#25888

It might be beneficial if we are able to view changes in submodules directly in a PR instead of only a hash.
@YoukouTenhouin YoukouTenhouin self-assigned this Nov 13, 2024
@YoukouTenhouin YoukouTenhouin converted this from a draft issue Nov 13, 2024
@YoukouTenhouin
Copy link
Collaborator Author

No planned activities until it's prioriotized

@JanZerebecki JanZerebecki added this to the after 1st release milestone Jan 20, 2025
@AdamMajer AdamMajer added the gitea UI feature label Jan 29, 2025
@AdamMajer AdamMajer moved this from 📋 Backlog to 👀 In review in Git Workflow Planning Jan 30, 2025
@AdamMajer
Copy link
Member

Upstream will be adding this in 1.24.0. A diff in submodules has a link to a compare page in the submodule with its changes. The submodule must be on the server for this to work.

@AdamMajer AdamMajer moved this from 👀 In review to ✅ Done in Git Workflow Planning Jan 31, 2025
@AdamMajer AdamMajer closed this as completed by moving to ✅ Done in Git Workflow Planning Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YoukouTenhouin YoukouTenhouin

Labels
gitea UI feature
Projects
Git Workflow Planning
Status: ✅ Done
Milestone
after 1st release
Development

No branches or pull requests
3 participants
@AdamMajer @YoukouTenhouin @JanZerebecki