fix(parsing): don't default to an empty

Author: RobertCraigie

src/lib/parser.ts

@@ -119,7 +119,7 @@ export function maybeParseChatCompletion<
       ...completion,
       choices: completion.choices.map((choice) => ({
         ...choice,
-        message: { ...choice.message, parsed: null, tool_calls: choice.message.tool_calls ?? [] },
+        message: { ...choice.message, parsed: null, tool_calls: choice.message.tool_calls ?? undefined },
       })),
     };
   }
@@ -144,7 +144,8 @@ export function parseChatCompletion<
       ...choice,
       message: {
         ...choice.message,
-        tool_calls: choice.message.tool_calls?.map((toolCall) => parseToolCall(params, toolCall)) ?? [],
+        tool_calls:
+          choice.message.tool_calls?.map((toolCall) => parseToolCall(params, toolCall)) ?? undefined,
         parsed:
           choice.message.content && !choice.message.refusal ?
             parseResponseFormat(params, choice.message.content)

src/resources/beta/chat/completions.ts

@@ -50,7 +50,7 @@ export interface ParsedFunctionToolCall extends ChatCompletionMessageToolCall {
 
 export interface ParsedChatCompletionMessage<ParsedT> extends ChatCompletionMessage {
   parsed: ParsedT | null;
-  tool_calls: Array<ParsedFunctionToolCall>;
+  tool_calls?: Array<ParsedFunctionToolCall> | undefined;
 }
 
 export interface ParsedChoice<ParsedT> extends ChatCompletion.Choice {

src/resources/chat/completions/completions.ts

@@ -701,7 +701,7 @@ export interface ChatCompletionMessage {
   /**
    * The tool calls generated by the model, such as function calls.
    */
-  tool_calls?: Array<ChatCompletionMessageToolCall>;
+  tool_calls?: Array<ChatCompletionMessageToolCall> | undefined;
 }
 
 export namespace ChatCompletionMessage {

tests/lib/ChatCompletionRunFunctions.test.ts

@@ -628,7 +628,7 @@ describe('resource completions', () => {
           content: "it's raining",
           parsed: null,
           refusal: null,
-          tool_calls: [],
+          tool_calls: undefined,
         },
       ]);
       expect(listener.functionCallResults).toEqual([`it's raining`]);
@@ -876,7 +876,7 @@ describe('resource completions', () => {
           content: 'there are 3 properties in {"a": 1, "b": 2, "c": 3}',
           parsed: null,
           refusal: null,
-          tool_calls: [],
+          tool_calls: undefined,
         },
       ]);
       expect(listener.functionCallResults).toEqual(['3']);
@@ -1125,7 +1125,7 @@ describe('resource completions', () => {
           content: 'there are 3 properties in {"a": 1, "b": 2, "c": 3}',
           parsed: null,
           refusal: null,
-          tool_calls: [],
+          tool_calls: undefined,
         },
       ]);
       expect(listener.functionCallResults).toEqual([`must be an object`, '3']);
@@ -1443,7 +1443,7 @@ describe('resource completions', () => {
           content: "it's raining",
           parsed: null,
           refusal: null,
-          tool_calls: [],
+          tool_calls: undefined,
         },
       ]);
       expect(listener.functionCallResults).toEqual([
@@ -1572,7 +1572,7 @@ describe('resource completions', () => {
           content: "it's raining",
           parsed: null,
           refusal: null,
-          tool_calls: [],
+          tool_calls: undefined,
         },
       ]);
       expect(listener.eventFunctionCallResults).toEqual([`it's raining`]);
@@ -1795,7 +1795,7 @@ describe('resource completions', () => {
           content: 'there are 3 properties in {"a": 1, "b": 2, "c": 3}',
           parsed: null,
           refusal: null,
-          tool_calls: [],
+          tool_calls: undefined,
         },
       ]);
       expect(listener.eventFunctionCallResults).toEqual(['3']);
@@ -1997,7 +1997,7 @@ describe('resource completions', () => {
           content: 'there are 3 properties in {"a": 1, "b": 2, "c": 3}',
           parsed: null,
           refusal: null,
-          tool_calls: [],
+          tool_calls: undefined,
         },
       ]);
       expect(listener.eventFunctionCallResults).toEqual([`must be an object`, '3']);
@@ -2301,7 +2301,7 @@ describe('resource completions', () => {
           content: "it's raining",
           parsed: null,
           refusal: null,
-          tool_calls: [],
+          tool_calls: undefined,
         },
       ]);
       expect(listener.eventFunctionCallResults).toEqual([
@@ -2347,7 +2347,7 @@ describe('resource completions', () => {
         content: 'The weather is great today!',
         parsed: null,
         refusal: null,
-        tool_calls: [],
+        tool_calls: undefined,
       });
       await listener.sanityCheck();
     });
@@ -2386,7 +2386,7 @@ describe('resource completions', () => {
         content: 'The weather is great today!',
         parsed: null,
         refusal: null,
-        tool_calls: [],
+        tool_calls: undefined,
       });
       await listener.sanityCheck();
     });

tests/lib/ChatCompletionStream.test.ts

@@ -39,7 +39,7 @@ describe('.stream()', () => {
           },
           "refusal": null,
           "role": "assistant",
-          "tool_calls": [],
+          "tool_calls": undefined,
         },
       }
     `);
@@ -198,7 +198,7 @@ describe('.stream()', () => {
           },
           "refusal": null,
           "role": "assistant",
-          "tool_calls": [],
+          "tool_calls": undefined,
         },
       }
     `);
@@ -386,7 +386,7 @@ describe('.stream()', () => {
           "parsed": null,
           "refusal": "I'm very sorry, but I can't assist with that request.",
           "role": "assistant",
-          "tool_calls": [],
+          "tool_calls": undefined,
         },
       }
     `);

tests/lib/parser.test.ts

@@ -39,7 +39,7 @@ describe('.parse()', () => {
             },
             "refusal": null,
             "role": "assistant",
-            "tool_calls": [],
+            "tool_calls": undefined,
           },
         }
       `);
@@ -154,7 +154,7 @@ describe('.parse()', () => {
           },
           "refusal": null,
           "role": "assistant",
-          "tool_calls": [],
+          "tool_calls": undefined,
         }
       `);
 
@@ -488,7 +488,7 @@ describe('.parse()', () => {
           },
           "refusal": null,
           "role": "assistant",
-          "tool_calls": [],
+          "tool_calls": undefined,
         }
       `);
     });
@@ -787,7 +787,7 @@ describe('.parse()', () => {
           },
           "refusal": null,
           "role": "assistant",
-          "tool_calls": [],
+          "tool_calls": undefined,
         }
       `);
     });
@@ -947,7 +947,7 @@ describe('.parse()', () => {
           },
           "refusal": null,
           "role": "assistant",
-          "tool_calls": [],
+          "tool_calls": undefined,
         }
       `);
     });
@@ -1061,7 +1061,7 @@ describe('.parse()', () => {
           },
           "refusal": null,
           "role": "assistant",
-          "tool_calls": [],
+          "tool_calls": undefined,
         }
       `);
     });