Skip to content

Commit a0fb5f4

Browse files
openshift-merge-bot[bot]openshift-merge-bot[bot]
authored
Merge pull request #2353 from djoshy/add-azure-fg
MCO-1671: Add feature gates for azure boot image updates & skew management
2 parents 7f6237c + 5a9ea32 commit a0fb5f4

8 files changed

+72
-18
lines changed

‎features.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
| MachineAPIOperatorDisableMachineHealthCheckController| | | | | | |
66
| MultiArchInstallAzure| | | | | | |
77
| ShortCertRotation| | | | | | |
8+
| BootImageSkewEnforcement| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | |
89
| ClusterVersionOperatorConfiguration| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | |
910
| DualReplica| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | |
1011
| Example2| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | |
@@ -42,6 +43,7 @@
4243
| KMSEncryptionProvider| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
4344
| MachineAPIMigration| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
4445
| MachineConfigNodes| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
46+
| ManagedBootImagesAzure| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
4547
| ManagedBootImagesvSphere| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
4648
| MaxUnavailableStatefulSet| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
4749
| MinimumKubeletVersion| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |

‎features/features.go

Lines changed: 34 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -133,12 +133,12 @@ var (
133133
mustRegister()
134134

135135
FeatureGateAzureDedicatedHosts = newFeatureGate("AzureDedicatedHosts").
136-
reportProblemsToJiraComponent("installer").
137-
contactPerson("rvanderp3").
138-
productScope(ocpSpecific).
139-
enhancementPR("https://github.com/openshift/enhancements/pull/1783").
140-
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
141-
mustRegister()
136+
reportProblemsToJiraComponent("installer").
137+
contactPerson("rvanderp3").
138+
productScope(ocpSpecific).
139+
enhancementPR("https://github.com/openshift/enhancements/pull/1783").
140+
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
141+
mustRegister()
142142

143143
FeatureGateMaxUnavailableStatefulSet = newFeatureGate("MaxUnavailableStatefulSet").
144144
reportProblemsToJiraComponent("apps").
@@ -385,6 +385,22 @@ var (
385385
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
386386
mustRegister()
387387

388+
FeatureGateManagedBootImagesAzure = newFeatureGate("ManagedBootImagesAzure").
389+
reportProblemsToJiraComponent("MachineConfigOperator").
390+
contactPerson("djoshy").
391+
productScope(ocpSpecific).
392+
enhancementPR("https://github.com/openshift/enhancements/pull/1761").
393+
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
394+
mustRegister()
395+
396+
FeatureGateBootImageSkewEnforcement = newFeatureGate("BootImageSkewEnforcement").
397+
reportProblemsToJiraComponent("MachineConfigOperator").
398+
contactPerson("djoshy").
399+
productScope(ocpSpecific).
400+
enhancementPR("https://github.com/openshift/enhancements/pull/1761").
401+
enableIn(configv1.DevPreviewNoUpgrade).
402+
mustRegister()
403+
388404
FeatureGateOnClusterBuild = newFeatureGate("OnClusterBuild").
389405
reportProblemsToJiraComponent("MachineConfigOperator").
390406
contactPerson("cheesesashimi").
@@ -808,18 +824,18 @@ var (
808824
mustRegister()
809825

810826
FeatureGatePreconfiguredUDNAddresses = newFeatureGate("PreconfiguredUDNAddresses").
811-
reportProblemsToJiraComponent("Networking/ovn-kubernetes").
812-
contactPerson("kyrtapz").
813-
productScope(ocpSpecific).
814-
enhancementPR("https://github.com/openshift/enhancements/pull/1793").
815-
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
816-
mustRegister()
827+
reportProblemsToJiraComponent("Networking/ovn-kubernetes").
828+
contactPerson("kyrtapz").
829+
productScope(ocpSpecific).
830+
enhancementPR("https://github.com/openshift/enhancements/pull/1793").
831+
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
832+
mustRegister()
817833

818834
FeatureGateAWSServiceLBNetworkSecurityGroup = newFeatureGate("AWSServiceLBNetworkSecurityGroup").
819-
reportProblemsToJiraComponent("Cloud Compute / Cloud Controller Manager").
820-
contactPerson("mtulio").
821-
productScope(ocpSpecific).
822-
enhancementPR("https://github.com/openshift/enhancements/pull/1802").
823-
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
824-
mustRegister()
835+
reportProblemsToJiraComponent("Cloud Compute / Cloud Controller Manager").
836+
contactPerson("mtulio").
837+
productScope(ocpSpecific).
838+
enhancementPR("https://github.com/openshift/enhancements/pull/1802").
839+
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
840+
mustRegister()
825841
)

‎payload-manifests/featuregates/featureGate-Hypershift-Default.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@
3131
{
3232
"name": "AzureMultiDisk"
3333
},
34+
{
35+
"name": "BootImageSkewEnforcement"
36+
},
3437
{
3538
"name": "BootcNodeManagement"
3639
},
@@ -112,6 +115,9 @@
112115
{
113116
"name": "MachineConfigNodes"
114117
},
118+
{
119+
"name": "ManagedBootImagesAzure"
120+
},
115121
{
116122
"name": "ManagedBootImagesvSphere"
117123
},

‎payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,9 @@
8080
{
8181
"name": "AzureWorkloadIdentity"
8282
},
83+
{
84+
"name": "BootImageSkewEnforcement"
85+
},
8386
{
8487
"name": "BootcNodeManagement"
8588
},
@@ -191,6 +194,9 @@
191194
{
192195
"name": "ManagedBootImagesAWS"
193196
},
197+
{
198+
"name": "ManagedBootImagesAzure"
199+
},
194200
{
195201
"name": "ManagedBootImagesvSphere"
196202
},

‎payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@
1515
"featureGates": [
1616
{
1717
"disabled": [
18+
{
19+
"name": "BootImageSkewEnforcement"
20+
},
1821
{
1922
"name": "ClusterAPIInstall"
2023
},
@@ -197,6 +200,9 @@
197200
{
198201
"name": "ManagedBootImagesAWS"
199202
},
203+
{
204+
"name": "ManagedBootImagesAzure"
205+
},
200206
{
201207
"name": "ManagedBootImagesvSphere"
202208
},

‎payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@
3131
{
3232
"name": "AzureMultiDisk"
3333
},
34+
{
35+
"name": "BootImageSkewEnforcement"
36+
},
3437
{
3538
"name": "BootcNodeManagement"
3639
},
@@ -115,6 +118,9 @@
115118
{
116119
"name": "MachineConfigNodes"
117120
},
121+
{
122+
"name": "ManagedBootImagesAzure"
123+
},
118124
{
119125
"name": "ManagedBootImagesvSphere"
120126
},

‎payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,9 @@
6565
{
6666
"name": "AzureWorkloadIdentity"
6767
},
68+
{
69+
"name": "BootImageSkewEnforcement"
70+
},
6871
{
6972
"name": "BootcNodeManagement"
7073
},
@@ -176,6 +179,9 @@
176179
{
177180
"name": "ManagedBootImagesAWS"
178181
},
182+
{
183+
"name": "ManagedBootImagesAzure"
184+
},
179185
{
180186
"name": "ManagedBootImagesvSphere"
181187
},

‎payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@
1515
"featureGates": [
1616
{
1717
"disabled": [
18+
{
19+
"name": "BootImageSkewEnforcement"
20+
},
1821
{
1922
"name": "ClusterAPIInstall"
2023
},
@@ -182,6 +185,9 @@
182185
{
183186
"name": "ManagedBootImagesAWS"
184187
},
188+
{
189+
"name": "ManagedBootImagesAzure"
190+
},
185191
{
186192
"name": "ManagedBootImagesvSphere"
187193
},

0 commit comments

Comments
 (0)