Skip to content

Commit 86b8bf5

Browse files
committed
provide a bogus value for DNS base path, we throw this away later but it prevents a conditional in the installer
1 parent d7faee6 commit 86b8bf5

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

pkg/installer/generateconfig.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -238,6 +238,12 @@ func (m *manager) generateInstallConfig(ctx context.Context) (*installconfig.Ins
238238
CloudName: azuretypes.CloudEnvironment(m.env.Environment().Name),
239239
OutboundType: outboundType,
240240
ResourceGroupName: resourceGroup,
241+
// We specify BaseDomainResourceGroupName even though we
242+
// do not create Public DNS zones to pass validation.
243+
// See https://issues.redhat.com/browse/OCPSTRAT-991 for
244+
// a more permanent fix (disabling public DNS
245+
// provisioning).
246+
BaseDomainResourceGroupName: resourceGroup,
241247
},
242248
},
243249
PullSecret: pullSecret,

0 commit comments

Comments
 (0)