Skip to content

Commit 6ebcdd3

Browse files
bobbypageehashman
authored andcommitted
kubelet: update cAdvisor usage for v0.43
* Change cAdvisor manager constructor * Change call to adding AcceleratorUsageMetrics Signed-off-by: David Porter <[email protected]>
1 parent df7f8f3 commit 6ebcdd3

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

pkg/kubelet/cadvisor/cadvisor_linux.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ func New(imageFsInfoProvider ImageFsInfoProvider, rootPath string, cgroupRoots [
115115
}
116116

117117
// Create the cAdvisor container manager.
118-
m, err := manager.New(memory.New(statsCacheDuration, nil), sysFs, housekeepingConfig, includedMetrics, http.DefaultClient, cgroupRoots, "")
118+
m, err := manager.New(memory.New(statsCacheDuration, nil), sysFs, housekeepingConfig, includedMetrics, http.DefaultClient, cgroupRoots, nil /* containerEnvMetadataWhiteList */, "" /* perfEventsFile */, time.Duration(0) /*resctrlInterval*/)
119119
if err != nil {
120120
return nil, err
121121
}

pkg/kubelet/server/server.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ func (s *Server) InstallDefaultHandlers() {
372372
// Only add the Accelerator metrics if the feature is inactive
373373
// Note: Accelerator metrics will be removed in the future, hence the feature gate.
374374
if !utilfeature.DefaultFeatureGate.Enabled(features.DisableAcceleratorUsageMetrics) {
375-
includedMetrics.Add(cadvisormetrics.MetricKind(cadvisormetrics.AcceleratorUsageMetrics))
375+
includedMetrics[cadvisormetrics.AcceleratorUsageMetrics] = struct{}{}
376376
}
377377

378378
cadvisorOpts := cadvisorv2.RequestOptions{

0 commit comments

Comments
 (0)