NO-JIRA: Display whoami information as JSON or YAML #1324

christianh814 · 2023-01-19T00:27:45Z

Added an option -o or --output that displays the user information in YAML or JSON.

Closes: #1323

Signed-off-by: Christian Hernandez [email protected]

christianh814 · 2023-01-19T03:41:10Z

/retest-required

christianh814 · 2023-01-20T18:26:28Z

/retest-required

Signed-off-by: Christian Hernandez <[email protected]> changing to output of json or yaml Signed-off-by: Christian Hernandez <[email protected]> updated to use output of yaml or json Signed-off-by: Christian Hernandez <[email protected]> added the GVK to the output Signed-off-by: Christian Hernandez <[email protected]>

christianh814 · 2023-01-20T22:59:58Z

/retest-required

christianh814 · 2023-01-21T15:48:16Z

/retest-required

christianh814 · 2023-01-24T20:12:48Z

/test e2e-aws-ovn-serial

openshift-ci · 2023-03-20T22:14:19Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: christianh814
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2023-03-21T00:37:51Z

@christianh814: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-upgrade	`25e26e6`	link	true	`/test e2e-aws-ovn-upgrade`
ci/prow/e2e-aws-ovn-serial	`25e26e6`	link	true	`/test e2e-aws-ovn-serial`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2023-06-19T09:01:05Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

christianh814 · 2023-06-19T19:43:31Z

/remove-lifecycle stale

openshift-bot · 2023-09-18T09:33:05Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2023-10-19T00:30:49Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

christianh814 · 2023-10-19T00:50:49Z

/remove-lifecycle rotten

christianh814 · 2024-01-17T03:13:57Z

/remove-lifecycle stale

openshift-bot · 2024-04-16T09:01:08Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

christianh814 · 2024-04-16T14:07:55Z

/remove-lifecycle stale.

openshift-bot · 2024-05-17T00:30:14Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

christianh814 · 2024-05-17T03:02:37Z

/remove-lifecycle rotten

openshift-bot · 2024-08-15T09:00:48Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

christianh814 · 2024-08-15T14:31:00Z

/remove-lifecycle stale

openshift-bot · 2024-11-14T01:01:08Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

christianh814 · 2024-11-18T18:56:35Z

/remove-lifecycle stale

openshift-bot · 2025-02-17T01:00:28Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

christianh814 · 2025-02-18T16:51:14Z

/remove-lifecycle stale

vrutkovs · 2025-05-16T08:37:01Z

/retitle NO-JIRA: Display whoami information as JSON or YAML
/refresh

@ardaguclu PTAL

openshift-ci-robot · 2025-05-16T08:37:32Z

@christianh814: This pull request explicitly references no jira issue.

In response to this:

Added an option -o or --output that displays the user information in YAML or JSON.

Closes: #1323

Signed-off-by: Christian Hernandez [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

kaovilai · 2025-05-16T19:11:12Z

@vrutkovs fyi jira exists here: https://issues.redhat.com/browse/RFE-3594 should we use that?

christianh814 · 2025-05-16T19:11:23Z

/retitle NO-JIRA: Display whoami information as JSON or YAML /refresh

@ardaguclu PTAL

@vrutkovs JIRA was created 2 years ago https://issues.redhat.com/browse/RFE-3594

vrutkovs · 2025-05-17T05:50:14Z

This RFE seems deferred, so we'll need a bug or a task ticket for this. In any case, JIRA ticket here is required if we want to backport it - and it can be done later

ardaguclu

Thank you for this PR. However, SelfSubjectReview takes precedence over User object in OpenShift. So that this PR needs to be modified accordingly.

ardaguclu · 2025-05-20T06:00:26Z

pkg/cli/whoami/whoami.go

@@ -153,14 +164,34 @@ func (o *WhoAmIOptions) Run() error {
 		}
 		fmt.Fprintf(o.Out, "%s\n", consoleUrl)
 		return nil
-	}
+	case o.Output == "yaml":
+		u, err := o.UserInterface.Users().Get(context.TODO(), "~", metav1.GetOptions{})


SelfSubjectReview needs to take precedence over UserInterface (logic

oc/pkg/cli/whoami/whoami.go

Lines 88 to 107 in 093ad87

res, err := o.AuthV1Client.SelfSubjectReviews().Create(context.TODO(), &v1.SelfSubjectReview{}, metav1.CreateOptions{})

if err == nil {

me := &userv1.User{

ObjectMeta: metav1.ObjectMeta{

Name: res.Status.UserInfo.Username,

},

Groups: res.Status.UserInfo.Groups,

}

fmt.Fprintf(o.Out, "%s\n", me.Name)

return me, nil

} else {

klog.V(2).Infof("selfsubjectreview request error %v, falling back to user object", err)

}

me, err := o.UserInterface.Users().Get(context.TODO(), "~", metav1.GetOptions{})

if err == nil {

fmt.Fprintf(o.Out, "%s\n", me.Name)

}

return me, err

). Actually, there is no need to duplicate the effort. Why can't we print what we get in WhoAmI function.

ardaguclu · 2025-05-20T06:01:33Z

pkg/cli/whoami/whoami.go

+		}
+		fmt.Fprintf(o.Out, "%s\n", string(y))
+		return nil
+	case o.Output == "json":


We can use built-in printing flags to print yaml and json files. Example, https://github.com/kubernetes/kubectl/blob/5ff92a69e3ecb06912d5f468186d458bf610244e/pkg/cmd/auth/whoami.go#L64

ardaguclu · 2025-05-20T06:02:18Z

pkg/cli/whoami/whoami.go

@@ -47,6 +49,8 @@ type WhoAmIOptions struct {
 	ShowContext    bool
 	ShowServer     bool
 	ShowConsoleUrl bool
+	ShowGroups     bool


Unused and not related to this PR?

openshift-ci bot requested review from ardaguclu and deads2k January 19, 2023 00:28

christianh814 marked this pull request as draft January 20, 2023 04:08

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2023

christianh814 changed the title ~~added show-groups option to display group membership~~ WIP: Display User information as JSON or YAML Jan 20, 2023

christianh814 marked this pull request as ready for review January 20, 2023 15:44

openshift-ci bot requested review from mfojtik and soltysh January 20, 2023 15:44

christianh814 force-pushed the whoami-show-groups branch from 26f79b8 to 790d0f4 Compare January 20, 2023 19:57

christianh814 changed the title ~~WIP: Display User information as JSON or YAML~~ Display whoami information as JSON or YAML Jan 20, 2023

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2023

Merge branch 'openshift:master' into whoami-show-groups

25e26e6

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 19, 2023

openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 19, 2023

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 18, 2023

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 19, 2023

openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 17, 2024

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 16, 2024

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 17, 2024

openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 17, 2024

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 15, 2024

openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 15, 2024

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 14, 2024

openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 18, 2024

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 17, 2025

openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 18, 2025

openshift-ci bot changed the title ~~Display whoami information as JSON or YAML~~ NO-JIRA: Display whoami information as JSON or YAML May 16, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 16, 2025

ardaguclu reviewed May 20, 2025

View reviewed changes

	res, err := o.AuthV1Client.SelfSubjectReviews().Create(context.TODO(), &v1.SelfSubjectReview{}, metav1.CreateOptions{})
	if err == nil {
	me := &userv1.User{
	ObjectMeta: metav1.ObjectMeta{
	Name: res.Status.UserInfo.Username,
	},
	Groups: res.Status.UserInfo.Groups,
	}
	fmt.Fprintf(o.Out, "%s\n", me.Name)
	return me, nil
	} else {
	klog.V(2).Infof("selfsubjectreview request error %v, falling back to user object", err)
	}

	me, err := o.UserInterface.Users().Get(context.TODO(), "~", metav1.GetOptions{})
	if err == nil {
	fmt.Fprintf(o.Out, "%s\n", me.Name)
	}

	return me, err

NO-JIRA: Display whoami information as JSON or YAML #1324

Are you sure you want to change the base?

NO-JIRA: Display whoami information as JSON or YAML #1324

Uh oh!

Conversation

christianh814 commented Jan 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

christianh814 commented Jan 19, 2023

Uh oh!

christianh814 commented Jan 20, 2023

Uh oh!

christianh814 commented Jan 20, 2023

Uh oh!

christianh814 commented Jan 21, 2023

Uh oh!

christianh814 commented Jan 24, 2023

Uh oh!

openshift-ci bot commented Mar 20, 2023

Uh oh!

openshift-ci bot commented Mar 21, 2023

Uh oh!

openshift-bot commented Jun 19, 2023

Uh oh!

christianh814 commented Jun 19, 2023

Uh oh!

openshift-bot commented Sep 18, 2023

Uh oh!

openshift-bot commented Oct 19, 2023

Uh oh!

christianh814 commented Oct 19, 2023

Uh oh!

christianh814 commented Jan 17, 2024

Uh oh!

openshift-bot commented Apr 16, 2024

Uh oh!

christianh814 commented Apr 16, 2024

Uh oh!

openshift-bot commented May 17, 2024

Uh oh!

christianh814 commented May 17, 2024

Uh oh!

openshift-bot commented Aug 15, 2024

Uh oh!

christianh814 commented Aug 15, 2024

Uh oh!

openshift-bot commented Nov 14, 2024

Uh oh!

christianh814 commented Nov 18, 2024

Uh oh!

openshift-bot commented Feb 17, 2025

Uh oh!

christianh814 commented Feb 18, 2025

Uh oh!

vrutkovs commented May 16, 2025

Uh oh!

openshift-ci-robot commented May 16, 2025

Uh oh!

kaovilai commented May 16, 2025

Uh oh!

christianh814 commented May 16, 2025

Uh oh!

vrutkovs commented May 17, 2025

Uh oh!

ardaguclu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ardaguclu May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ardaguclu May 20, 2025

Choose a reason for hiding this comment

Uh oh!

ardaguclu May 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

christianh814 commented Jan 19, 2023 •

edited

Loading

ardaguclu left a comment •

edited

Loading

ardaguclu May 20, 2025 •

edited

Loading