Skip to content

[BUG] Fix scale and autoscale oc completion #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BUG] Fix scale and autoscale oc completion #1994

wants to merge 1 commit into from

Conversation

hadasgayer
Copy link

This PR fixes #1993.

I've added the relevant resources to the validArgs array and set the ValidArgsFunction in oc's scale and autoscale commands - the existing ValidArgs wasn't appropriate and also didn't work because it's not set in the original commands.
I'm not sure whether machineSet should be included in this array as well since it may not be relevant for all openshift clusters.

@openshift-ci openshift-ci bot requested review from atiratree and deads2k March 21, 2025 11:48
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 21, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hadasgayer
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 21, 2025

Hi @hadasgayer. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atiratree atiratree Awaiting requested review from atiratree

@deads2k deads2k Awaiting requested review from deads2k

Assignees
No one assigned
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scale and Autoscale completion does not work as intended
1 participant
@hadasgayer