Skip to content

Commit 0619576

Browse files
committed
Add additional API groups to security check whitelist
Add the OpenShift API groups for whitelisted resources as well as the `apps` group for deployments to the security whitelist.
1 parent 649b78e commit 0619576

File tree

2 files changed

+32
-0
lines changed

2 files changed

+32
-0
lines changed

app/scripts/constants.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,18 +106,25 @@ angular.extend(window.OPENSHIFT_CONSTANTS, {
106106
// and Import YAML/JSON. This typically shouldn't be customized but can be if necessary.
107107
SECURITY_CHECK_WHITELIST: [
108108
{resource: 'buildconfigs', group: ''},
109+
{resource: 'buildconfigs', group: 'build.openshift.io'},
109110
{resource: 'builds', group: ''},
111+
{resource: 'builds', group: 'build.openshift.io'},
110112
{resource: 'configmaps', group: ''},
111113
{resource: 'daemonsets', group: 'extensions'},
114+
{resource: 'deployments', group: 'apps'},
112115
{resource: 'deployments', group: 'extensions'},
113116
{resource: 'deploymentconfigs', group: ''},
117+
{resource: 'deploymentconfigs', group: 'apps.openshift.io'},
114118
{resource: 'endpoints', group: ''},
115119
{resource: 'events', group: ''},
116120
{resource: 'horizontalpodautoscalers', group: 'autoscaling'},
117121
{resource: 'horizontalpodautoscalers', group: 'extensions'},
118122
{resource: 'imagestreamimages', group: ''},
123+
{resource: 'imagestreamimages', group: 'image.openshift.io'},
119124
{resource: 'imagestreams', group: ''},
125+
{resource: 'imagestreams', group: 'image.openshift.io'},
120126
{resource: 'imagestreamtags', group: ''},
127+
{resource: 'imagestreamtags', group: 'image.openshift.io'},
121128
{resource: 'ingresses', group: 'extensions'},
122129
{resource: 'jobs', group: 'batch'},
123130
{resource: 'persistentvolumeclaims', group: ''},
@@ -126,6 +133,7 @@ angular.extend(window.OPENSHIFT_CONSTANTS, {
126133
{resource: 'replicasets', group: 'extensions'},
127134
{resource: 'replicationcontrollers', group: ''},
128135
{resource: 'routes', group: ''},
136+
{resource: 'routes', group: 'route.openshift.io'},
129137
{resource: 'secrets', group: ''},
130138
{resource: 'serviceaccounts', group: ''},
131139
{resource: 'services', group: ''},

dist/scripts/scripts.js

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -592,21 +592,33 @@ SECURITY_CHECK_WHITELIST:[ {
592592
resource:"buildconfigs",
593593
group:""
594594
}, {
595+
resource:"buildconfigs",
596+
group:"build.openshift.io"
597+
}, {
595598
resource:"builds",
596599
group:""
597600
}, {
601+
resource:"builds",
602+
group:"build.openshift.io"
603+
}, {
598604
resource:"configmaps",
599605
group:""
600606
}, {
601607
resource:"daemonsets",
602608
group:"extensions"
603609
}, {
604610
resource:"deployments",
611+
group:"apps"
612+
}, {
613+
resource:"deployments",
605614
group:"extensions"
606615
}, {
607616
resource:"deploymentconfigs",
608617
group:""
609618
}, {
619+
resource:"deploymentconfigs",
620+
group:"apps.openshift.io"
621+
}, {
610622
resource:"endpoints",
611623
group:""
612624
}, {
@@ -622,12 +634,21 @@ group:"extensions"
622634
resource:"imagestreamimages",
623635
group:""
624636
}, {
637+
resource:"imagestreamimages",
638+
group:"image.openshift.io"
639+
}, {
625640
resource:"imagestreams",
626641
group:""
627642
}, {
643+
resource:"imagestreams",
644+
group:"image.openshift.io"
645+
}, {
628646
resource:"imagestreamtags",
629647
group:""
630648
}, {
649+
resource:"imagestreamtags",
650+
group:"image.openshift.io"
651+
}, {
631652
resource:"ingresses",
632653
group:"extensions"
633654
}, {
@@ -652,6 +673,9 @@ group:""
652673
resource:"routes",
653674
group:""
654675
}, {
676+
resource:"routes",
677+
group:"route.openshift.io"
678+
}, {
655679
resource:"secrets",
656680
group:""
657681
}, {

0 commit comments

Comments
 (0)