Bug 1462205 - Delete binding shouldn't show up when all bindings are pending deletion

Author: jwforres

app/scripts/controllers/overview.js

@@ -1101,6 +1101,7 @@ function OverviewController($scope,
     // - API objects by binding name
     state.bindingsByApplicationUID = {};
     state.applicationsByBinding = {};
+    state.validBindingsByApplicationUID = {};
 
     // If there are no bindings, nothing to do.
     if (_.isEmpty(state.bindings)) {
@@ -1139,6 +1140,7 @@ function OverviewController($scope,
         // pod preset covers the selector.
         var applicationSelector = new LabelSelector(_.get(apiObject, 'spec.selector'));
         state.bindingsByApplicationUID[applicationUID] = [];
+        state.validBindingsByApplicationUID[applicationUID] = [];
 
         // Look at each pod preset selector to see if it covers this API object selector.
         _.each(podPresetSelectors, function(podPresetSelector, bindingName) {
@@ -1147,6 +1149,9 @@ function OverviewController($scope,
             // the target. We want to show bindings both in the "application"
             // object rows and the service instance rows.
             state.bindingsByApplicationUID[applicationUID].push(state.bindings[bindingName]);
+            if (!_.get(state.bindings[bindingName], 'metadata.deletionTimestamp')) {
+              state.validBindingsByApplicationUID[applicationUID].push(state.bindings[bindingName]);
+            }
             state.applicationsByBinding[bindingName] = state.applicationsByBinding[bindingName] || [];
             state.applicationsByBinding[bindingName].push(apiObject);
           }

app/scripts/directives/overview/serviceInstanceRow.js

@@ -41,6 +41,7 @@
       row.notifications = ListRowUtils.getNotifications(row.apiObject, row.state);
       row.displayName = serviceInstanceDisplayName(row.apiObject, row.serviceClasses);
       row.description = getDescription();
+      row.validBindings = _.reject(row.bindings, 'metadata.deletionTimestamp');
     };
 
     row.getSecretForBinding = function(binding) {

app/views/overview/_list-row-actions.html

@@ -25,10 +25,10 @@
             </li>
             <!-- FIXME: Can't enable canI checks on svc cat resources until we have aggregation
             <li ng-if="(row.state.serviceInstances | hashSize) > 0 && {resource: 'bindings', group: 'servicecatalog.k8s.io'} | canI : 'create'" role="menuitem"> -->
-            <li ng-if-start="('pod_presets' | enableTechPreviewFeature) && row.state.bindableServiceInstances.length" role="menuitem">
+            <li ng-if="('pod_presets' | enableTechPreviewFeature) && row.state.bindableServiceInstances.length" role="menuitem">
               <a href="" ng-click="row.showOverlayPanel('bindService', {target: row.apiObject})">Create Binding</a>
             </li>
-            <li ng-if-end role="menuitem">
+            <li ng-if="('pod_presets' | enableTechPreviewFeature) && row.state.validBindingsByApplicationUID[row.apiObject.metadata.uid].length" role="menuitem">
               <a href="" ng-click="row.showOverlayPanel('unbindService', {target: row.apiObject})">Delete Binding</a>
             </li>
             <li ng-if="row.current && ('deploymentconfigs/log' | canI : 'get')" role="menuitem">

app/views/overview/_service-instance-row.html

@@ -55,7 +55,7 @@ <h3>
           <li role="menuitem" ng-if="('pod_presets' | enableTechPreviewFeature) && row.isBindable">
             <a href="" ng-click="row.showOverlayPanel('bindService', {target: row.apiObject})">Create Binding</a>
           </li>
-          <li role="menuitem" ng-if="('pod_presets' | enableTechPreviewFeature) && row.bindings.length">
+          <li role="menuitem" ng-if="('pod_presets' | enableTechPreviewFeature) && row.validBindings.length">
             <a href="" ng-click="row.showOverlayPanel('unbindService', {target: row.apiObject})">Delete Binding</a>
           </li>
           <li role="menuitem">
@@ -127,7 +127,10 @@ <h3>
             </div>
           </div>
           <div class="col-sm-7 col-md-6 overview-bindings">
-            <span ng-if="!(binding | isBindingReady)">
+            <span ng-if="binding.metadata.deletionTimestamp">
+              <status-icon status="'Pending'"></status-icon> Deleting
+            </span>
+            <span ng-if="!(binding | isBindingReady) && !binding.metadata.deletionTimestamp">
               <status-icon status="'Pending'"></status-icon> Pending
             </span>
             <a

dist/scripts/scripts.js

@@ -368,7 +368,7 @@ errorNotification:!1
 Q.secrets = a.by("metadata.name");
 });
 }, 300), $a = function() {
-if (Q.bindingsByApplicationUID = {}, Q.applicationsByBinding = {}, !_.isEmpty(Q.bindings)) {
+if (Q.bindingsByApplicationUID = {}, Q.applicationsByBinding = {}, Q.validBindingsByApplicationUID = {}, !_.isEmpty(Q.bindings)) {
 var a = [ z.deploymentConfigs, z.vanillaReplicationControllers, z.deployments, z.vanillaReplicaSets, z.statefulSets ];
 if (!_.some(a, function(a) {
 return !a;
@@ -380,8 +380,8 @@ c && (b[a.metadata.name] = new LabelSelector(c));
 }), _.each(a, function(a) {
 _.each(a, function(a) {
 var c = T(a), d = new LabelSelector(_.get(a, "spec.selector"));
-Q.bindingsByApplicationUID[c] = [], _.each(b, function(b, e) {
-b.covers(d) && (Q.bindingsByApplicationUID[c].push(Q.bindings[e]), Q.applicationsByBinding[e] = Q.applicationsByBinding[e] || [], Q.applicationsByBinding[e].push(a));
+Q.bindingsByApplicationUID[c] = [], Q.validBindingsByApplicationUID[c] = [], _.each(b, function(b, e) {
+b.covers(d) && (Q.bindingsByApplicationUID[c].push(Q.bindings[e]), _.get(Q.bindings[e], "metadata.deletionTimestamp") || Q.validBindingsByApplicationUID[c].push(Q.bindings[e]), Q.applicationsByBinding[e] = Q.applicationsByBinding[e] || [], Q.applicationsByBinding[e].push(a));
 });
 });
 });
@@ -13078,7 +13078,7 @@ var a = g.apiObject.spec.serviceClassName;
 return _.get(g, [ "state", "serviceClasses", a, "description" ]);
 };
 g.$doCheck = function() {
-g.notifications = e.getNotifications(g.apiObject, g.state), g.displayName = i(g.apiObject, g.serviceClasses), g.description = j();
+g.notifications = e.getNotifications(g.apiObject, g.state), g.displayName = i(g.apiObject, g.serviceClasses), g.description = j(), g.validBindings = _.reject(g.bindings, "metadata.deletionTimestamp");
 }, g.getSecretForBinding = function(a) {
 return a && _.get(g, [ "state", "secrets", a.spec.secretName ]);
 }, g.isBindable = d.isServiceBindable(g.apiObject, g.state.serviceClasses), g.closeOverlayPanel = function() {

dist/scripts/templates.js

@@ -11640,10 +11640,10 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "<a ng-href=\"{{row.apiObject | editResourceURL}}\">Edit</a>\n" +
     "</li>\n" +
     "\n" +
-    "<li ng-if-start=\"('pod_presets' | enableTechPreviewFeature) && row.state.bindableServiceInstances.length\" role=\"menuitem\">\n" +
+    "<li ng-if=\"('pod_presets' | enableTechPreviewFeature) && row.state.bindableServiceInstances.length\" role=\"menuitem\">\n" +
     "<a href=\"\" ng-click=\"row.showOverlayPanel('bindService', {target: row.apiObject})\">Create Binding</a>\n" +
     "</li>\n" +
-    "<li ng-if-end role=\"menuitem\">\n" +
+    "<li ng-if=\"('pod_presets' | enableTechPreviewFeature) && row.state.validBindingsByApplicationUID[row.apiObject.metadata.uid].length\" role=\"menuitem\">\n" +
     "<a href=\"\" ng-click=\"row.showOverlayPanel('unbindService', {target: row.apiObject})\">Delete Binding</a>\n" +
     "</li>\n" +
     "<li ng-if=\"row.current && ('deploymentconfigs/log' | canI : 'get')\" role=\"menuitem\">\n" +
@@ -12238,7 +12238,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "<li role=\"menuitem\" ng-if=\"('pod_presets' | enableTechPreviewFeature) && row.isBindable\">\n" +
     "<a href=\"\" ng-click=\"row.showOverlayPanel('bindService', {target: row.apiObject})\">Create Binding</a>\n" +
     "</li>\n" +
-    "<li role=\"menuitem\" ng-if=\"('pod_presets' | enableTechPreviewFeature) && row.bindings.length\">\n" +
+    "<li role=\"menuitem\" ng-if=\"('pod_presets' | enableTechPreviewFeature) && row.validBindings.length\">\n" +
     "<a href=\"\" ng-click=\"row.showOverlayPanel('unbindService', {target: row.apiObject})\">Delete Binding</a>\n" +
     "</li>\n" +
     "<li role=\"menuitem\">\n" +
@@ -12288,7 +12288,10 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "</div>\n" +
     "</div>\n" +
     "<div class=\"col-sm-7 col-md-6 overview-bindings\">\n" +
-    "<span ng-if=\"!(binding | isBindingReady)\">\n" +
+    "<span ng-if=\"binding.metadata.deletionTimestamp\">\n" +
+    "<status-icon status=\"'Pending'\"></status-icon> Deleting\n" +
+    "</span>\n" +
+    "<span ng-if=\"!(binding | isBindingReady) && !binding.metadata.deletionTimestamp\">\n" +
     "<status-icon status=\"'Pending'\"></status-icon> Pending\n" +
     "</span>\n" +
     "<a ng-if=\"(binding | isBindingReady) && ('secrets' | canI : 'get')\" ng-href=\"{{row.getSecretForBinding(binding) | navigateResourceURL}}\">\n" +