Skip to content

Commit a94c2f2

Browse files
author
OpenShift Bot
authored
Merge pull request #1739 from jwforres/delete-svc-cat-resources
Merged by openshift-bot
2 parents 54c8cb2 + 4bfb961 commit a94c2f2

File tree

4 files changed

+18
-4
lines changed

4 files changed

+18
-4
lines changed

app/scripts/directives/deleteLink.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,11 @@ angular.module("openshiftConsole")
147147
deleteOptions.gracePeriodSeconds = 0;
148148
}
149149

150+
// TODO - remove once this is resolved https://github.com/kubernetes-incubator/service-catalog/issues/942
151+
if (scope.group === 'servicecatalog.k8s.io') {
152+
deleteOptions.propagationPolicy = null;
153+
}
154+
150155
DataService.delete({
151156
resource: APIService.kindToResource(kind),
152157
// group or undefined

app/scripts/directives/overview/serviceInstanceRow.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,8 @@
9292
resource: 'instances'
9393
},
9494
row.apiObject.metadata.name,
95-
{ namespace: row.apiObject.metadata.namespace })
95+
{ namespace: row.apiObject.metadata.namespace },
96+
{ propagationPolicy: null }) // TODO - remove once this is resolved https://github.com/kubernetes-incubator/service-catalog/issues/942
9697
.then(function() {
9798
NotificationsService.addNotification({
9899
type: "success",

app/scripts/directives/unbindService.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,11 @@
2929
DataService.delete({
3030
group: 'servicecatalog.k8s.io',
3131
resource: 'bindings'
32-
}, ctrl.selectedBinding.metadata.name, context).then(_.noop, function(err) {
32+
},
33+
ctrl.selectedBinding.metadata.name,
34+
context,
35+
{ propagationPolicy: null })
36+
.then(_.noop, function(err) {
3337
ctrl.error = err;
3438
});
3539
};

dist/scripts/scripts.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8842,7 +8842,7 @@ b.result.then(function() {
88428842
var a = d.kind, b = d.resourceName, e = d.typeDisplayName || c("humanizeKind")(a), h = e + " '" + (d.displayName ? d.displayName :b) + "'", k = "Project" === d.kind ? {} :{
88438843
namespace:d.projectName
88448844
}, l = {};
8845-
d.options.deleteImmediately && (l.gracePeriodSeconds = 0), g["delete"]({
8845+
d.options.deleteImmediately && (l.gracePeriodSeconds = 0), "servicecatalog.k8s.io" === d.group && (l.propagationPolicy = null), g["delete"]({
88468846
resource:f.kindToResource(a),
88478847
group:d.group
88488848
}, b, k, l).then(function() {
@@ -12342,7 +12342,9 @@ var d, e, f = this, g = b("serviceInstanceDisplayName"), h = function() {
1234212342
c["delete"]({
1234312343
group:"servicecatalog.k8s.io",
1234412344
resource:"bindings"
12345-
}, f.selectedBinding.metadata.name, e).then(_.noop, function(a) {
12345+
}, f.selectedBinding.metadata.name, e, {
12346+
propagationPolicy:null
12347+
}).then(_.noop, function(a) {
1234612348
f.error = a;
1234712349
});
1234812350
}, i = function() {
@@ -13126,6 +13128,8 @@ group:"servicecatalog.k8s.io",
1312613128
resource:"instances"
1312713129
}, g.apiObject.metadata.name, {
1312813130
namespace:g.apiObject.metadata.namespace
13131+
}, {
13132+
propagationPolicy:null
1312913133
}).then(function() {
1313013134
f.addNotification({
1313113135
type:"success",

0 commit comments

Comments
 (0)