Skip to content

Commit c7290c8

Browse files
committed
Hide storage classes select when there are none
1 parent c298116 commit c7290c8

File tree

4 files changed

+9
-4
lines changed

4 files changed

+9
-4
lines changed

app/scripts/directives/oscPersistentVolumeClaim.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,10 @@ angular.module("openshiftConsole")
8484

8585
DataService.list({group: 'storage.k8s.io', resource: 'storageclasses'}, {}, function(storageClassData) {
8686
var storageClasses = storageClassData.by('metadata.name');
87+
if (_.isEmpty(storageClasses)) {
88+
return;
89+
}
90+
8791
scope.storageClasses = _.sortBy(storageClasses, 'metadata.name');
8892
var annotation = $filter('annotation');
8993
scope.defaultStorageClass = _.find(scope.storageClasses, function(storageClass) {

app/views/directives/osc-persistent-volume-claim.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
<ng-form name="persistentVolumeClaimForm">
22
<fieldset ng-disabled="claimDisabled">
3-
<div ng-show="storageClasses | hashSize" class="form-group">
3+
<div ng-if="storageClasses.length" class="form-group">
44
<!--storage class-->
55
<label>Storage Class</label>
66
<div>
77
<ui-select
8-
ng-if="storageClasses"
98
ng-model="claim.storageClass"
109
theme="bootstrap"
1110
search-enabled="true"

dist/scripts/scripts.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10262,6 +10262,7 @@ group:"storage.k8s.io",
1026210262
resource:"storageclasses"
1026310263
}, {}, function(b) {
1026410264
var c = b.by("metadata.name");
10265+
if (!_.isEmpty(c)) {
1026510266
e.storageClasses = _.sortBy(c, "metadata.name");
1026610267
var d = a("annotation");
1026710268
if (e.defaultStorageClass = _.find(e.storageClasses, function(a) {
@@ -10278,6 +10279,7 @@ description:"No storage class will be assigned"
1027810279
};
1027910280
e.storageClasses.unshift(f);
1028010281
}
10282+
}
1028110283
}, {
1028210284
errorNotification:!1
1028310285
}), b.list("limitranges", {

dist/scripts/templates.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7791,11 +7791,11 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
77917791
$templateCache.put('views/directives/osc-persistent-volume-claim.html',
77927792
"<ng-form name=\"persistentVolumeClaimForm\">\n" +
77937793
"<fieldset ng-disabled=\"claimDisabled\">\n" +
7794-
"<div ng-show=\"storageClasses | hashSize\" class=\"form-group\">\n" +
7794+
"<div ng-if=\"storageClasses.length\" class=\"form-group\">\n" +
77957795
"\n" +
77967796
"<label>Storage Class</label>\n" +
77977797
"<div>\n" +
7798-
"<ui-select ng-if=\"storageClasses\" ng-model=\"claim.storageClass\" theme=\"bootstrap\" search-enabled=\"true\" title=\"Select a storage class\" class=\"select-role\">\n" +
7798+
"<ui-select ng-model=\"claim.storageClass\" theme=\"bootstrap\" search-enabled=\"true\" title=\"Select a storage class\" class=\"select-role\">\n" +
77997799
"<ui-select-match placeholder=\"Select a storage class\">\n" +
78007800
"<span>\n" +
78017801
"{{$select.selected.metadata.name}}\n" +

0 commit comments

Comments
 (0)