Update overview to use toast notifications

Author: spadgett

app/scripts/controllers/overview.js

@@ -19,6 +19,7 @@ angular.module('openshiftConsole').controller('OverviewController', [
   'Logger',
   'MetricsService',
   'Navigate',
+  'NotificationsService',
   'OwnerReferencesService',
   'PodsService',
   'ProjectsService',
@@ -45,6 +46,7 @@ function OverviewController($scope,
                             Logger,
                             MetricsService,
                             Navigate,
+                            NotificationsService,
                             OwnerReferencesService,
                             PodsService,
                             ProjectsService,
@@ -1087,16 +1089,36 @@ function OverviewController($scope,
     $scope.$evalAsync(updateFilter);
   });
 
-  overview.startBuild = function(buildConfig) {
+  // This is used by the overview empty state message and also the list row,
+  // which is why it's assigned to the `state` object.
+  overview.startBuild = state.startBuild = function(buildConfig) {
+    var buildType = isJenkinsPipelineStrategy(buildConfig) ? 'pipeline' : 'build';
     BuildsService
       .startBuild(buildConfig.metadata.name, { namespace: buildConfig.metadata.namespace })
-      .then(_.noop, function(result) {
-        var buildType = isJenkinsPipelineStrategy(buildConfig) ? 'pipeline' : 'build';
-        state.alerts["start-build"] = {
+      .then(function(build) {
+        var buildName;
+        var buildNumber = annotation(build, 'buildNumber');
+        var buildURL = Navigate.resourceURL(build);
+        if (buildNumber) {
+          buildName = buildConfig.metadata.name + " #" + buildNumber;
+        } else {
+          buildName = build.metadata.name;
+        }
+
+        NotificationsService.addNotification({
+          type: "success",
+          message: _.capitalize(buildType) + " " + buildName + " successfully created.",
+          links: [{
+            href: buildURL,
+            label: 'View ' + _.capitalize(buildType)
+          }]
+        });
+      }, function(result) {
+        NotificationsService.addNotification({
           type: "error",
           message: "An error occurred while starting the " + buildType + ".",
           details: getErrorDetails(result)
-        };
+        });
       });
   };
 

app/scripts/directives/overview/listRow.js

@@ -8,8 +8,9 @@
       'APIService',
       'BuildsService',
       'DeploymentsService',
-      'Navigate',
       'ListRowUtils',
+      'Navigate',
+      'NotificationsService',
       OverviewListRow
     ],
     controllerAs: 'row',
@@ -29,17 +30,16 @@
                            APIService,
                            BuildsService,
                            DeploymentsService,
+                           ListRowUtils,
                            Navigate,
-                           rowMethods) {
+                           NotificationsService) {
     var row = this;
 
-    _.extend(row, rowMethods.ui);
+    _.extend(row, ListRowUtils.ui);
 
     var canI = $filter('canI');
     var deploymentIsInProgress = $filter('deploymentIsInProgress');
-    var getErrorDetails = $filter('getErrorDetails');
     var isBinaryBuild = $filter('isBinaryBuild');
-    var isJenkinsPipelineStrategy = $filter('isJenkinsPipelineStrategy');
 
     var updateTriggers = function(apiObject) {
       var triggers = _.get(apiObject, 'spec.triggers');
@@ -95,7 +95,7 @@
 
     row.$doCheck = function() {
       // Update notifications.
-      row.notifications = rowMethods.getNotifications(row.apiObject, row.state);
+      row.notifications = ListRowUtils.getNotifications(row.apiObject, row.state);
 
       // Update HPA.
       row.hpa = getHPA(row.apiObject);
@@ -213,18 +213,8 @@
       return canI('buildconfigs/instantiate', 'create') && _.size(row.pipelines) === 1;
     };
 
-    row.startBuild = function(buildConfig) {
-      BuildsService
-        .startBuild(buildConfig.metadata.name, { namespace: buildConfig.metadata.namespace })
-        .then(_.noop, function(result) {
-          var buildType = isJenkinsPipelineStrategy(buildConfig) ? 'pipeline' : 'build';
-          row.state.alerts["start-build"] = {
-            type: "error",
-            message: "An error occurred while starting the " + buildType + ".",
-            details: getErrorDetails(result)
-          };
-        });
-    };
+    // Resuse the function from the overview controller.
+    row.startBuild = row.state.startBuild;
 
     row.canDeploy = function() {
       if (!row.apiObject) {
@@ -291,10 +281,10 @@
 
       modalInstance.result.then(function() {
         if (replicationController.metadata.uid !== row.current.metadata.uid) {
-          row.state.alerts["cancel-deployment"] = {
+          NotificationsService.addNotification({
             type: "error",
             message: "Deployment #" + latestVersion + " is no longer the latest."
-          };
+          });
           return;
         }
 
@@ -303,10 +293,10 @@
 
         // Make sure it's still running.
         if (!deploymentIsInProgress(replicationController)) {
-          row.state.alerts["cancel-deployment"] = {
+          NotificationsService.addNotification({
             type: "error",
             message: "Deployment " + rcName + " is no longer in progress."
-          };
+          });
           return;
         }
 

app/scripts/directives/overview/serviceInstanceRow.js

@@ -4,9 +4,10 @@
   angular.module('openshiftConsole').component('serviceInstanceRow', {
     controller: [
       '$filter',
+      '$uibModal',
       'DataService',
       'ListRowUtils',
-      '$uibModal',
+      'NotificationsService',
       ServiceInstanceRow
     ],
     controllerAs: 'row',
@@ -18,9 +19,13 @@
     templateUrl: 'views/overview/_service-instance-row.html'
   });
 
-  function ServiceInstanceRow($filter, DataService, rowMethods, $uibModal) {
+  function ServiceInstanceRow($filter,
+                              $uibModal,
+                              DataService,
+                              ListRowUtils,
+                              NotificationsService) {
     var row = this;
-    _.extend(row, rowMethods.ui);
+    _.extend(row, ListRowUtils.ui);
 
     var getErrorDetails = $filter('getErrorDetails');
 
@@ -37,7 +42,7 @@
     };
 
     row.$doCheck = function() {
-      row.notifications = rowMethods.getNotifications(row.apiObject, row.state);
+      row.notifications = ListRowUtils.getNotifications(row.apiObject, row.state);
       row.displayName = getDisplayName();
       row.description = getDescription();
     };
@@ -83,23 +88,25 @@
         }
       })
       .result.then(function() {
+        NotificationsService.hideNotification("deprovision-service-error");
         DataService.delete({
           group: 'servicecatalog.k8s.io',
           resource: 'instances'
         },
         row.apiObject.metadata.name,
         { namespace: row.apiObject.metadata.namespace })
         .then(function() {
-          row.state.alerts["start-build"] = {
+          NotificationsService.addNotification({
             type: "success",
-            message: "Successfully deprovisioned " + row.apiObject.metadata.name
-          };
+            message: "Successfully deprovisioned " + row.apiObject.metadata.name + "."
+          });
         }, function(err) {
-          row.state.alerts["start-build"] = {
+          NotificationsService.addNotification({
+            id: "deprovision-service-error",
             type: "error",
-            message: "An error occurred while deprovisioning " + row.apiObject.metadata.name,
-            details: "Reason: " + getErrorDetails(err)
-          };
+            message: "An error occurred while deprovisioning " + row.apiObject.metadata.name + ".",
+            details: getErrorDetails(err)
+          });
         });
       });
     };