use cmdutil DryRun flag helper

Author: juanvallejo

pkg/cmd/cli/cmd/create/clusterquota.go

@@ -62,7 +62,7 @@ func NewCmdCreateClusterQuota(name, fullName string, f *clientcmd.Factory, out i
 	}
 
 	cmdutil.AddPrinterFlags(cmd)
-	cmd.Flags().BoolVarP(&o.DryRun, "dry-run", "", false, "If true, only print the object that would be sent, without sending it.")
+	cmdutil.AddDryRunFlag(cmd)
 	cmd.Flags().String("project-label-selector", "", "The project label selector for the cluster resource quota")
 	cmd.Flags().String("project-annotation-selector", "", "The project annotation selector for the cluster resource quota")
 	cmd.Flags().StringSlice("hard", []string{}, "The resource to constrain: RESOURCE=QUANTITY (pods=10)")
@@ -74,6 +74,8 @@ func (o *CreateClusterQuotaOptions) Complete(cmd *cobra.Command, f *clientcmd.Fa
 		return fmt.Errorf("NAME is required: %v", args)
 	}
 
+	o.DryRun = cmdutil.GetFlagBool(cmd, "dry-run")
+
 	var labelSelector *unversioned.LabelSelector
 	labelSelectorString := cmdutil.GetFlagString(cmd, "project-label-selector")
 	if len(labelSelectorString) > 0 {

pkg/cmd/cli/cmd/create/deploymentconfig.go

@@ -57,9 +57,9 @@ func NewCmdCreateDeploymentConfig(name, fullName string, f *clientcmd.Factory, o
 		Aliases: []string{"dc"},
 	}
 
-	cmd.Flags().BoolVarP(&o.DryRun, "dry-run", "", false, "If true, only print the object that would be sent, without sending it.")
 	cmd.Flags().String("image", "", "The image for the container to run.")
 	cmd.MarkFlagRequired("image")
+	cmdutil.AddDryRunFlag(cmd)
 	cmdutil.AddPrinterFlags(cmd)
 	return cmd
 }
@@ -76,6 +76,7 @@ func (o *CreateDeploymentConfigOptions) Complete(cmd *cobra.Command, f *clientcm
 
 	labels := map[string]string{"deployment-config.name": args[0]}
 
+	o.DryRun = cmdutil.GetFlagBool(cmd, "dry-run")
 	o.DC = &deployapi.DeploymentConfig{
 		ObjectMeta: kapi.ObjectMeta{Name: args[0]},
 		Spec: deployapi.DeploymentConfigSpec{

pkg/cmd/cli/cmd/create/identity.go

@@ -63,7 +63,7 @@ func NewCmdCreateIdentity(name, fullName string, f *clientcmd.Factory, out io.Wr
 		},
 	}
 
-	cmd.Flags().BoolVarP(&o.DryRun, "dry-run", "", false, "If true, only print the object that would be sent, without sending it.")
+	cmdutil.AddDryRunFlag(cmd)
 	cmdutil.AddPrinterFlags(cmd)
 	return cmd
 }
@@ -83,6 +83,8 @@ func (o *CreateIdentityOptions) Complete(cmd *cobra.Command, f *clientcmd.Factor
 		return fmt.Errorf("exactly one argument (username) is supported, not: %v", args)
 	}
 
+	o.DryRun = cmdutil.GetFlagBool(cmd, "dry-run")
+
 	client, _, err := f.Clients()
 	if err != nil {
 		return err

pkg/cmd/cli/cmd/create/imagestream.go

@@ -59,7 +59,7 @@ func NewCmdCreateImageStream(name, fullName string, f *clientcmd.Factory, out io
 	}
 
 	cmdutil.AddPrinterFlags(cmd)
-	cmd.Flags().BoolVarP(&o.DryRun, "dry-run", "", false, "If true, only print the object that would be sent, without sending it.")
+	cmdutil.AddDryRunFlag(cmd)
 	return cmd
 }
 
@@ -69,6 +69,8 @@ func (o *CreateImageStreamOptions) Complete(cmd *cobra.Command, f *clientcmd.Fac
 		Spec:       imageapi.ImageStreamSpec{},
 	}
 
+	o.DryRun = cmdutil.GetFlagBool(cmd, "dry-run")
+
 	switch len(args) {
 	case 0:
 		return fmt.Errorf("image stream name is required")

pkg/cmd/cli/cmd/create/route.go

@@ -71,7 +71,7 @@ func NewCmdCreateEdgeRoute(fullName string, f *clientcmd.Factory, out io.Writer)
 
 	kcmdutil.AddValidateFlags(cmd)
 	kcmdutil.AddPrinterFlags(cmd)
-	cmd.Flags().Bool("dry-run", false, "If true, only print the route that would be created, without creating it.")
+	kcmdutil.AddDryRunFlag(cmd)
 	cmd.Flags().String("hostname", "", "Set a hostname for the new route")
 	cmd.Flags().String("port", "", "Name of the service port or number of the container port the route will route traffic to")
 	cmd.Flags().String("insecure-policy", "", "Set an insecure policy for the new route")
@@ -198,7 +198,7 @@ func NewCmdCreatePassthroughRoute(fullName string, f *clientcmd.Factory, out io.
 
 	kcmdutil.AddValidateFlags(cmd)
 	kcmdutil.AddPrinterFlags(cmd)
-	cmd.Flags().Bool("dry-run", false, "If true, only print the route that would be created, without creating it.")
+	kcmdutil.AddDryRunFlag(cmd)
 	cmd.Flags().String("hostname", "", "Set a hostname for the new route")
 	cmd.Flags().String("port", "", "Name of the service port or number of the container port the route will route traffic to")
 	cmd.Flags().String("service", "", "Name of the service that the new route is exposing")
@@ -297,7 +297,7 @@ func NewCmdCreateReencryptRoute(fullName string, f *clientcmd.Factory, out io.Wr
 
 	kcmdutil.AddValidateFlags(cmd)
 	kcmdutil.AddPrinterFlags(cmd)
-	cmd.Flags().Bool("dry-run", false, "If true, only print the route that would be created, without creating it.")
+	kcmdutil.AddDryRunFlag(cmd)
 	cmd.Flags().String("hostname", "", "Set a hostname for the new route")
 	cmd.Flags().String("port", "", "Name of the service port or number of the container port the route will route traffic to")
 	cmd.Flags().String("service", "", "Name of the service that the new route is exposing")

pkg/cmd/cli/cmd/create/user.go

@@ -62,7 +62,7 @@ func NewCmdCreateUser(name, fullName string, f *clientcmd.Factory, out io.Writer
 		},
 	}
 	cmd.Flags().StringVar(&o.FullName, "full-name", o.FullName, "Display name of the user")
-	cmd.Flags().BoolVarP(&o.DryRun, "dry-run", "", false, "If true, only print the object that would be sent, without sending it.")
+	cmdutil.AddDryRunFlag(cmd)
 	cmdutil.AddPrinterFlags(cmd)
 	return cmd
 }
@@ -77,6 +77,8 @@ func (o *CreateUserOptions) Complete(cmd *cobra.Command, f *clientcmd.Factory, a
 		return fmt.Errorf("exactly one argument (username) is supported, not: %v", args)
 	}
 
+	o.DryRun = cmdutil.GetFlagBool(cmd, "dry-run")
+
 	client, _, err := f.Clients()
 	if err != nil {
 		return err

pkg/cmd/cli/cmd/create/user_identity_mapping.go

@@ -59,7 +59,7 @@ func NewCmdCreateUserIdentityMapping(name, fullName string, f *clientcmd.Factory
 		},
 	}
 	cmdutil.AddPrinterFlags(cmd)
-	cmd.Flags().BoolVarP(&o.DryRun, "dry-run", "", false, "If true, only print the object that would be sent, without sending it.")
+	cmdutil.AddDryRunFlag(cmd)
 	return cmd
 }
 
@@ -76,6 +76,8 @@ func (o *CreateUserIdentityMappingOptions) Complete(cmd *cobra.Command, f *clien
 		return fmt.Errorf("exactly two arguments (identity and user name) are supported, not: %v", args)
 	}
 
+	o.DryRun = cmdutil.GetFlagBool(cmd, "dry-run")
+
 	client, _, err := f.Clients()
 	if err != nil {
 		return err