test/extended/cli/admin: Add 'oc adm upgrade recommend' smoke test

I hear that folks want something similar to the OpenShift API conditions
[1]:

  1. Tests must contain either [OCPFeatureGate:<FeatureGateName>] or
     the standard upstream [FeatureGate:<FeatureGateName>].
  2. There must be at least five tests for each FeatureGate.
  3. Every test must be run on every TechPreview platform we have jobs
     for. (Ask for an exception if your feature doesn't support a
     variant.)
  ...

before promoting command-line features to GA.  Or maybe that is a
condition before shifting them from alpha to beta, like [2] moving an
upstream gate from IsEnabled to !IsDisabled?  Anyhow, I like testing,
and while in the origin suite we don't really know what, if anything,
we'll find in the ClusterVersion status properties the 'recommend'
command is reporting on, this commit at least runs the command to
confirm it doesn't fail to execute.

[1]: https://github.com/openshift/api/blob/9cbdb71c92bbae8d5939379844b8f84904806453/README.md#defining-featuregate-e2e-tests
[2]: https://github.com/kubernetes/kubernetes/pull/131818/files#diff-7e82ada63a2e6664b803ac3ccdb84759ac97338ce807df63be2f81e3c9e0ba9cR362

Author: wking

test/extended/cli/admin.go

@@ -620,6 +620,21 @@ var _ = g.Describe("[sig-cli] oc adm", func() {
 	// os::test::junit::declare_suite_end
 })
 
+var _ = g.Describe("[sig-cli][OCPFeatureGate:OCAdminUpgradeRecommend] oc adm upgrade recommend", func() {
+	defer g.GinkgoRecover()
+
+	f := framework.NewDefaultFramework("oc-adm-upgrade-recommend")
+	f.SkipNamespaceCreation = true
+
+	oc := exutil.NewCLIWithoutNamespace("oc-adm-upgrade-recommend").AsAdmin()
+
+	g.It("runs successfully, even without upstream OpenShift Update Service customization", func() {
+		out, err := oc.Run("adm", "upgrade", "recommend").EnvironmentVariables("OC_ENABLE_CMD_UPGRADE_RECOMMEND=true").Output()
+		o.Expect(err).NotTo(o.HaveOccurred())
+		o.Expect(out).To(o.MatchRegexp(`FIXME: not sure what to expect so fail`))
+	})
+})
+
 func randomNode(oc *exutil.CLI) string {
 	nodes, err := oc.AdminKubeClient().CoreV1().Nodes().List(context.Background(), metav1.ListOptions{})
 	o.Expect(err).NotTo(o.HaveOccurred())

test/extended/util/annotate/generated/zz_generated.annotations.go

@@ -96,6 +96,7 @@ type CLI struct {
 	globalArgs           []string
 	commandArgs          []string
 	finalArgs            []string
+	environmentVariables []string
 	namespacesToDelete   []string
 	stdin                *bytes.Buffer
 	stdout               io.Writer
@@ -908,6 +909,15 @@ func (c *CLI) Args(args ...string) *CLI {
 	return c
 }
 
+// EnvironmentVariables sets environment variables for the OpenShift CLI command.
+//
+// With the same semantics as exec.Cmd's Env property.
+// https://pkg.go.dev/os/exec#Cmd
+func (c *CLI) EnvironmentVariables(env ...string) *CLI {
+	c.environmentVariables = env
+	return c
+}
+
 func (c *CLI) printCmd() string {
 	return strings.Join(c.finalArgs, " ")
 }
@@ -947,6 +957,7 @@ func (c *CLI) start(stdOutBuff, stdErrBuff *bytes.Buffer) (*exec.Cmd, error) {
 		fmt.Printf("DEBUG: oc %s\n", c.printCmd())
 	}
 	cmd := exec.Command(c.execPath, c.finalArgs...)
+	cmd.Env = c.environmentVariables
 	cmd.Stdin = c.stdin
 	// Redact any bearer token information from the log.
 	framework.Logf("Running '%s %s'", c.execPath, RedactBearerToken(strings.Join(c.finalArgs, " ")))