Skip to content

Commit 3841346

Browse files
committed
collapse onto upstream version function
1 parent 51a3bbd commit 3841346

File tree

5 files changed

+5
-225
lines changed

5 files changed

+5
-225
lines changed

hack/import-restrictions.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -615,15 +615,13 @@
615615

616616
"vendor/github.com/coreos/etcd/clientv3",
617617
"vendor/github.com/coreos/etcd/pkg/transport",
618-
"vendor/github.com/coreos/etcd/version",
619618
"vendor/github.com/ghodss/yaml",
620619

621620
"vendor/k8s.io/kubernetes/pkg/api/legacyscheme",
622621
"vendor/k8s.io/kubernetes/pkg/controller",
623622
"vendor/k8s.io/kubernetes/pkg/controller/deployment/util",
624623
"vendor/k8s.io/kubernetes/pkg/credentialprovider",
625624
"vendor/k8s.io/kubernetes/pkg/serviceaccount",
626-
"vendor/k8s.io/kubernetes/pkg/version",
627625

628626
"vendor/github.com/openshift/library-go/pkg/git"
629627
]

pkg/oc/cli/admin/admin.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ import (
3939
"github.com/openshift/origin/pkg/oc/cli/admin/verifyimagesignature"
4040
"github.com/openshift/origin/pkg/oc/cli/kubectlwrappers"
4141
"github.com/openshift/origin/pkg/oc/cli/options"
42-
"github.com/openshift/origin/pkg/oc/cli/version"
4342
)
4443

4544
var adminLong = ktemplates.LongDesc(`
@@ -149,9 +148,5 @@ func NewCommandAdmin(name, fullName string, f kcmdutil.Factory, streams genericc
149148
options.NewCmdOptions(streams),
150149
)
151150

152-
if name == fullName {
153-
cmds.AddCommand(version.NewCmdVersion(fullName, f, version.NewVersionOptions(false, streams)))
154-
}
155-
156151
return cmds
157152
}

pkg/oc/cli/cli.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import (
1010

1111
"github.com/spf13/cobra"
1212

13+
kcmd "k8s.io/kubernetes/pkg/kubectl/cmd"
1314
kubecmd "k8s.io/kubernetes/pkg/kubectl/cmd"
1415
ktemplates "k8s.io/kubernetes/pkg/kubectl/cmd/templates"
1516
kcmdutil "k8s.io/kubernetes/pkg/kubectl/cmd/util"
@@ -60,7 +61,6 @@ import (
6061
"github.com/openshift/origin/pkg/oc/cli/startbuild"
6162
"github.com/openshift/origin/pkg/oc/cli/status"
6263
"github.com/openshift/origin/pkg/oc/cli/tag"
63-
"github.com/openshift/origin/pkg/oc/cli/version"
6464
"github.com/openshift/origin/pkg/oc/cli/whoami"
6565
)
6666

@@ -241,9 +241,7 @@ func NewCommandCLI(name, fullName string, in io.Reader, out, errout io.Writer) *
241241
cmds.AddCommand(newExperimentalCommand("ex", name+" ex", f, ioStreams))
242242

243243
cmds.AddCommand(kubectlwrappers.NewCmdPlugin(fullName, f, ioStreams))
244-
if name == fullName {
245-
cmds.AddCommand(version.NewCmdVersion(fullName, f, version.NewVersionOptions(true, ioStreams)))
246-
}
244+
cmds.AddCommand(kcmd.NewCmdVersion(f, ioStreams))
247245
cmds.AddCommand(options.NewCmdOptions(ioStreams))
248246

249247
if cmds.Flag("namespace") != nil {

pkg/oc/cli/shim_kubectl.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package cli
22

33
import (
44
kclientcmd "k8s.io/client-go/tools/clientcmd"
5+
kcmd "k8s.io/kubernetes/pkg/kubectl/cmd"
56
kcmdset "k8s.io/kubernetes/pkg/kubectl/cmd/set"
67
kcmdutil "k8s.io/kubernetes/pkg/kubectl/cmd/util"
78
"k8s.io/kubernetes/pkg/kubectl/genericclioptions"
@@ -11,6 +12,7 @@ import (
1112
"github.com/openshift/origin/pkg/api/legacygroupification"
1213
"github.com/openshift/origin/pkg/oc/originpolymorphichelpers"
1314
"github.com/openshift/origin/pkg/oc/util/clientcmd"
15+
"github.com/openshift/origin/pkg/version"
1416
)
1517

1618
func shimKubectlForOc() {
@@ -41,4 +43,5 @@ func shimKubectlForOc() {
4143
// update some functions we inject
4244
kcmdutil.GeneratorFn = originpolymorphichelpers.NewGeneratorsFn(kcmdutil.GeneratorFn)
4345
kcmdutil.DescriberFn = originpolymorphichelpers.NewDescriberFn(kcmdutil.DescriberFn)
46+
kcmd.OverrideGetVersionFn = version.Get
4447
}

pkg/oc/cli/version/version.go

Lines changed: 0 additions & 214 deletions
This file was deleted.

0 commit comments

Comments
 (0)