Skip to content

Commit 41b80f5

Browse files
committed
fixup! Remove port from request's Host header
Add integration tests.
1 parent 429f3d0 commit 41b80f5

File tree

1 file changed

+19
-0
lines changed

1 file changed

+19
-0
lines changed

test/integration/router_test.go

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -464,6 +464,10 @@ func TestRouterPathSpecificity(t *testing.T) {
464464
if _, err := getRoute(routeAddress, "www.example.com", "http", nil, ""); err != ErrUnavailable {
465465
t.Fatalf("unexpected response: %q", err)
466466
}
467+
//ensure you can curl path with port in Host header
468+
if err := waitForRoute(routeTestAddress, "www.example.com:80", "http", nil, tr.HelloPodPath); err != nil {
469+
t.Fatalf("unexpected response: %q", err)
470+
}
467471

468472
//create newer, conflicting path based route
469473
endpointEvent = &watch.Event{
@@ -499,6 +503,9 @@ func TestRouterPathSpecificity(t *testing.T) {
499503
if err := waitForRoute(routeTestAddress, "www.example.com", "http", nil, tr.HelloPodPath); err != nil {
500504
t.Fatalf("unexpected response: %q", err)
501505
}
506+
if err := waitForRoute(routeTestAddress, "www.example.com:80", "http", nil, tr.HelloPodPath); err != nil {
507+
t.Fatalf("unexpected response: %q", err)
508+
}
502509

503510
//create host based route
504511
routeEvent = &watch.Event{
@@ -526,6 +533,9 @@ func TestRouterPathSpecificity(t *testing.T) {
526533
if err := waitForRoute(routeAddress, "www.example.com", "http", nil, tr.HelloPod); err != nil {
527534
t.Fatalf("unexpected response: %q", err)
528535
}
536+
if err := waitForRoute(routeTestAddress, "www.example.com:80", "http", nil, tr.HelloPodPath); err != nil {
537+
t.Fatalf("unexpected response: %q", err)
538+
}
529539

530540
//delete path based route
531541
routeEvent = &watch.Event{
@@ -558,6 +568,9 @@ func TestRouterPathSpecificity(t *testing.T) {
558568
if err := waitForRoute(routeAddress, "www.example.com", "http", nil, tr.HelloPod); err != nil {
559569
t.Fatalf("unexpected response: %q", err)
560570
}
571+
if err := waitForRoute(routeTestAddress, "www.example.com:80", "http", nil, tr.HelloPodPath); err != nil {
572+
t.Fatalf("unexpected response: %q", err)
573+
}
561574

562575
// create newer, conflicting host based route that is ignored
563576
routeEvent = &watch.Event{
@@ -584,6 +597,9 @@ func TestRouterPathSpecificity(t *testing.T) {
584597
if err := waitForRoute(routeAddress, "www.example.com", "http", nil, tr.HelloPod); err != nil {
585598
t.Fatalf("unexpected response: %q", err)
586599
}
600+
if err := waitForRoute(routeTestAddress, "www.example.com:80", "http", nil, tr.HelloPodPath); err != nil {
601+
t.Fatalf("unexpected response: %q", err)
602+
}
587603

588604
//create old, conflicting host based route which should take over the route
589605
routeEvent = &watch.Event{
@@ -610,6 +626,9 @@ func TestRouterPathSpecificity(t *testing.T) {
610626
if err := waitForRoute(routeAddress, "www.example.com", "http", nil, tr.HelloPodAlternate); err != nil {
611627
t.Fatalf("unexpected response: %q", err)
612628
}
629+
if err := waitForRoute(routeTestAddress, "www.example.com:80", "http", nil, tr.HelloPodPath); err != nil {
630+
t.Fatalf("unexpected response: %q", err)
631+
}
613632

614633
// Clean up the host-based route and endpoint.
615634
routeEvent = &watch.Event{

0 commit comments

Comments
 (0)