get typed pods directly with restclient

Author: juanvallejo

pkg/cmd/admin/node/listpods.go

@@ -1,7 +1,6 @@
 package node
 
 import (
-	"encoding/json"
 	"fmt"
 
 	"github.com/spf13/cobra"
@@ -15,6 +14,7 @@ import (
 	kapiv1 "k8s.io/kubernetes/pkg/api/v1"
 	kcmdutil "k8s.io/kubernetes/pkg/kubectl/cmd/util"
 	kprinters "k8s.io/kubernetes/pkg/printers"
+	"k8s.io/kubernetes/staging/src/k8s.io/client-go/kubernetes/scheme"
 )
 
 type ListPodsOptions struct {
@@ -108,28 +108,22 @@ func (l *ListPodsOptions) handleRESTOutput(nodes []*kapi.Node, printer kprinters
 		}
 		fieldSelector := fields.Set{GetPodHostFieldLabel(node.TypeMeta.APIVersion): node.ObjectMeta.Name}.AsSelector()
 
-		pods, err := l.Options.KubeClient.Core().Pods(metav1.NamespaceAll).List(metav1.ListOptions{LabelSelector: labelSelector.String(), FieldSelector: fieldSelector.String()})
+		pods := &kapiv1.PodList{}
+
+		restClient := l.Options.KubeClient.Core().RESTClient()
+		err = restClient.Get().
+			Namespace(metav1.NamespaceAll).
+			Resource("pods").
+			VersionedParams(&metav1.ListOptions{LabelSelector: labelSelector.String(), FieldSelector: fieldSelector.String()}, scheme.ParameterCodec).
+			Do().
+			Into(pods)
 		if err != nil {
 			errList = append(errList, err)
 			continue
 		}
 
-		unifiedPodList.ListMeta.SelfLink = pods.ListMeta.SelfLink
-
 		for _, pod := range pods.Items {
-			typedPod := &kapiv1.Pod{}
-			b, err := json.Marshal(pod)
-			if err != nil {
-				errList = append(errList, err)
-				continue
-			}
-			err = json.Unmarshal(b, typedPod)
-			if err != nil {
-				errList = append(errList, err)
-				continue
-			}
-
-			unifiedPodList.Items = append(unifiedPodList.Items, *typedPod)
+			unifiedPodList.Items = append(unifiedPodList.Items, pod)
 		}
 	}