Skip to content

Commit 5204860

Browse files
Merge pull request #14568 from smarterclayton/deployinformer
Remove a duplicate deployment informer
2 parents ee15d99 + 656639d commit 5204860

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

pkg/cmd/server/kubernetes/master/master_config.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -343,6 +343,8 @@ func buildControllerManagerServer(masterConfig configapi.MasterConfig) (*cmapp.C
343343
componentconfig.GroupResource{Group: "oauth.openshift.io", Resource: "oauthauthorizetokens"},
344344
// exposed already as cronjobs
345345
componentconfig.GroupResource{Group: "batch", Resource: "scheduledjobs"},
346+
// exposed already as extensions v1beta1 by other controllers
347+
componentconfig.GroupResource{Group: "apps", Resource: "deployments"},
346348
)
347349

348350
// resolve extended arguments

pkg/cmd/server/origin/controller/image.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ func (c *ImageTriggerControllerConfig) RunController(ctx ControllerContext) (boo
6565
if !c.HasDeploymentsEnabled {
6666
sources = append(sources, imagetriggercontroller.TriggerSource{
6767
Resource: schema.GroupResource{Group: "extensions", Resource: "deployments"},
68-
Informer: ctx.DeprecatedOpenshiftInformers.KubernetesInformers().Apps().V1beta1().Deployments().Informer(),
69-
Store: ctx.DeprecatedOpenshiftInformers.KubernetesInformers().Apps().V1beta1().Deployments().Informer().GetIndexer(),
68+
Informer: ctx.DeprecatedOpenshiftInformers.KubernetesInformers().Extensions().V1beta1().Deployments().Informer(),
69+
Store: ctx.DeprecatedOpenshiftInformers.KubernetesInformers().Extensions().V1beta1().Deployments().Informer().GetIndexer(),
7070
TriggerFn: triggerannotations.NewAnnotationTriggerIndexer,
7171
Reactor: &triggerannotations.AnnotationReactor{Updater: updater, Copier: kapi.Scheme},
7272
})

0 commit comments

Comments
 (0)